Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change SYCL_PI_TESTS to SYCL_UR_TESTS in CI #16010

Merged

Conversation

omarahmed1111
Copy link
Contributor

SYCL_PI_TESTS was deprecated and changed to SYCL_UR_TESTS.

@omarahmed1111
Copy link
Contributor Author

@intel/llvm-gatekeepers please merge, Thanks!

@AlexeySachkov
Copy link
Contributor

AlexeySachkov commented Nov 8, 2024

I think that a better change would be to completely drop the option:

# TODO UR tests require real hardware and must be moved to sycl/test-e2e.

This comment is totally outdated, because the only UR unit-test we have is:

TEST(UrUtilityTest, CheckUrCastOCLEventVector) {
// Current special case for vectors of OpenCL vectors. This may change in the
// future.
std::vector<cl_event> EVec{(cl_event)0};
ur_native_handle_t ENativeHandle = detail::ur::cast<ur_native_handle_t>(EVec);
EXPECT_EQ(ENativeHandle, (ur_native_handle_t)EVec[0]);
}

The option seems to be some kind of legacy and that single test we have should be enabled by default

@omarahmed1111
Copy link
Contributor Author

I think that a better change would be to completely drop the option:

# TODO UR tests require real hardware and must be moved to sycl/test-e2e.

This comment is totally outdated, because the only UR unit-test we have is:

TEST(UrUtilityTest, CheckUrCastOCLEventVector) {
// Current special case for vectors of OpenCL vectors. This may change in the
// future.
std::vector<cl_event> EVec{(cl_event)0};
ur_native_handle_t ENativeHandle = detail::ur::cast<ur_native_handle_t>(EVec);
EXPECT_EQ(ENativeHandle, (ur_native_handle_t)EVec[0]);
}

The option seems to be some kind of legacy and that single test we have should be enabled by default

That make sense, removed the option.

@omarahmed1111 omarahmed1111 force-pushed the change-SYCL_PI_TESTS-to-SYCL_UR_TESTS branch from 71cc3b9 to 4ffd6db Compare November 8, 2024 17:14
@omarahmed1111
Copy link
Contributor Author

@intel/llvm-gatekeepers please merge, Thanks!

@martygrant martygrant merged commit ac3a03e into intel:sycl Nov 11, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants