-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add black GHA for changed files #1356
Conversation
a6c5366
to
1c49d78
Compare
faf3f86
to
6661df6
Compare
Thanks @ahuber21! Looks good to me. @napetrov @Alexsandruss could you please review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not clear how black
will affect code: for example, it changed license header when I manually applied it.
Using of it for only changed files will cause formatting inconsistency between changed part and old part of repo.
Well it reformats the license because it's not pep8 conform
Therefore The effect of We already have many style inconsistencies. I would prefer conserving a reasonable commit history for files that do not change often which is why I'm adding |
/intelci: run |
ef402cd
to
0a3f556
Compare
/intelci: run |
Provide a github action that runs black code formatting in PRs.
I'm trying to configure it such that only changed files are checked.