-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: align daal4py
, onedal
and sklearnex
modules with isort and black
#1375
MAINT: align daal4py
, onedal
and sklearnex
modules with isort and black
#1375
Conversation
Actually normalizing the entire project is something that I wanted to avoid. I think the commit history in rarely changed files (e.g. the code generators) is more important than code formatting. |
As I mentioned on the description, it seems to me that we can do it once. And we will get the commit message for refactoring in all files. |
daal4py
, onedal
and sklearnex
modules with isort and black
/intelci: run |
I am going to do changes in each of sklearnex and onedal module py files: refactoring testing, dpnp integration and I will touch each py file for the algo and utils, so that's why I need codestyle it before. I think further PRs will be mess up with code formatting in other case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have not reviewed all 200+ files.
But I think the changes are good as soon as they made by automated code formatting tool and passed the testing.
Let those go to master.
Description
Advantage:
Commit message will be "apply isort and black fixes only for
daal4py
,onedal
andsklearnex
modules"Disadvantage: