-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TEST: added different dataframes testing in sklearnex
own tests
#1379
TEST: added different dataframes testing in sklearnex
own tests
#1379
Conversation
… preview.linear, and svm modules disabled some test: see TODOs
/intelci: run |
In this PR, the number of sklearnex own test cases has increased. Added Unfortunately, there are 18 new failures for different reasons, that should be addressed in separate PRs. =========================== short test summary info ============================
FAILED neighbors/tests/test_neighbors.py::test_sklearnex_import_nn[dpctl-SyclQueue_CPU]
FAILED neighbors/tests/test_neighbors.py::test_sklearnex_import_nn[dpctl-SyclQueue_GPU]
FAILED neighbors/tests/test_neighbors.py::test_sklearnex_import_nn[dpnp-SyclQueue_CPU]
FAILED neighbors/tests/test_neighbors.py::test_sklearnex_import_nn[dpnp-SyclQueue_GPU]
FAILED preview/ensemble/tests/test_preview_ensemble.py::test_sklearnex_import_rf_regression[dpctl-SyclQueue_GPU]
FAILED preview/ensemble/tests/test_preview_ensemble.py::test_sklearnex_import_rf_regression[dpnp-SyclQueue_GPU]
FAILED preview/ensemble/tests/test_preview_ensemble.py::test_sklearnex_import_et_classifier[dpctl-SyclQueue_GPU]
FAILED preview/ensemble/tests/test_preview_ensemble.py::test_sklearnex_import_et_classifier[dpnp-SyclQueue_GPU]
FAILED preview/ensemble/tests/test_preview_ensemble.py::test_sklearnex_import_et_regression[dpctl-SyclQueue_GPU]
FAILED preview/ensemble/tests/test_preview_ensemble.py::test_sklearnex_import_et_regression[dpnp-SyclQueue_GPU]
FAILED svm/tests/test_svm.py::test_sklearnex_import_nusvc[dpctl-SyclQueue_GPU]
FAILED svm/tests/test_svm.py::test_sklearnex_import_nusvc[dpnp-SyclQueue_GPU]
FAILED svm/tests/test_svm.py::test_sklearnex_import_svc[dpctl-SyclQueue_GPU]
FAILED svm/tests/test_svm.py::test_sklearnex_import_svc[dpnp-SyclQueue_GPU]
FAILED svm/tests/test_svm.py::test_sklearnex_import_svr[dpctl-SyclQueue_GPU]
FAILED svm/tests/test_svm.py::test_sklearnex_import_svr[dpnp-SyclQueue_GPU]
FAILED svm/tests/test_svm.py::test_sklearnex_import_nusvr[dpctl-SyclQueue_GPU]
FAILED svm/tests/test_svm.py::test_sklearnex_import_nusvr[dpnp-SyclQueue_GPU]
===== 18 failed, 363 passed, 7 skipped, 429 warnings in 157.47s (0:02:37) ====== Currently, I have disabled this test cases via test filters + # TODO:
# investigate failure for `dpnp.ndarrays` and `dpctl.tensors` on `GPU`
@pytest.mark.parametrize(
"dataframe,queue", _get_dataframes_and_queues(device_filter_="cpu")
)
def test_sklearnex_import_et_classifier(dataframe, queue): We don't have list of sklearnex or onedal deselected test like we have for sklearn tests, see deselected_tests.yaml. I think we should extend sklearnex testing and add support of deselected tests for onedal4py and sklearnex modules instead of using filters. This is new feature, that should be implemented in separate branch. See TODO in [description] (#1379 (comment)) |
/intelci: run |
Job: http://intel-ci.intel.com/ee2ffcc8-9bec-f1c1-a4e7-a4bf010d0e2e. Specifically for sklearnex/daal4py tests/examples on GPU without dpnp on env. |
Job: http://intel-ci.intel.com/ee2ffd93-f8c6-f1de-bd22-a4bf010d0e2e. Specifically for sklearnex/daal4py tests/examples on GPU with |
/intelci: run |
/intelci: run |
/intelci: run |
Job: http://intel-ci.intel.com/ee318ac9-4082-f1b8-a4e7-a4bf010d0e2e. Specifically for sklearnex/daal4py tests/examples on GPU with dpctl and dpnp. |
Job: http://intel-ci.intel.com/ee31f782-83c1-f190-9df2-a4bf010d0e2e. Specifically for sklearnex/daal4py tests/examples on GPU with dpctl and dpnp. |
Job: http://intel-ci.intel.com/ee321570-cbcb-f141-9c8d-a4bf010d0e2e. Specifically for sklearnex/daal4py tests/examples on GPU with dpctl and dpnp. |
/intelci: run |
Job: http://intel-ci.intel.com/ee35e825-3d41-f126-b1a7-a4bf010d0e2e. Specifically for sklearnex/daal4py tests/examples on GPU with dpctl and dpnp. |
… this commit" This reverts commit 960071d.
/intelci: run |
Job: http://intel-ci.intel.com/ee369d0a-5daa-f1ea-b9eb-a4bf010d0e2e. Specifically for sklearnex/daal4py tests/examples on GPU with dpctl and dpnp. |
/intelci: run |
/intelci: run |
Latest CI check: http://intel-ci.intel.com/ee382f7b-9a45-f121-94b4-a4bf010d0e2e |
/intelci: run |
Only unnecessary check was failed and it is not related with the changes in PR at all |
Description
Added different dataframes testing in
sklearnex
own tests for checkingdpnp
anddpctl
interop insklearnex
._dataframes_support
modul in onedal tests utils. Will reuse for onedal4py tests also.sklearnex.neignbors
sklearnex.preview.decomposition
sklearnex.preview.ensemble
sklearnex.preview.linear_model
sklearnex.svm
Before:
After:
TODO:
deselcted_tests.yaml
for sklearnex tests. -> in seperate PR:sklearnex
own tests #1379 (comment)