Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: fallback to stock sklearn for Kmeans CSR inputs in train #2061

Closed

Conversation

samir-nasibli
Copy link
Contributor

@samir-nasibli samir-nasibli commented Sep 19, 2024

Description

Proposed Second option for 2025.0 release in case if oneapi-src/oneDAL#2906 will not full or mostly fix timeouts issue of Kmeans train with sparse inputs

Workaround for the timeouts, alternative for the deselection on #2059

Note:
If oneapi-src/oneDAL#2906 will succeed and resolve timout issues, will be preferred and
current #2061 and #2059 PRs will be closed.


Checklist to comply with before moving PR from draft:

PR completeness and readability

  • I have reviewed my changes thoroughly before submitting this pull request.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes or created a separate PR with update and provided its number in the description, if necessary.
  • Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
  • I have added a respective label(s) to PR if I have a permission for that.
  • I have resolved any merge conflicts that might occur with the base branch.

Testing

  • The unit tests pass successfully.
  • I have run it locally and tested the changes extensively.

Performance

  • I have measured performance for affected algorithms using scikit-learn_bench and provided at least summary table with measured data, if performance change is expected.
  • I have provided justification why performance has changed or why changes are not expected.

@ethanglaser
Copy link
Contributor

Covered by oneapi-src/oneDAL#2906

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants