Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set token permission for ci.yml #2162

Merged
merged 6 commits into from
Nov 13, 2024
Merged

Conversation

ethanglaser
Copy link
Contributor

@ethanglaser ethanglaser commented Nov 12, 2024

Description

Fix OpenSSF scan failure


PR should start as a draft, then move to ready for review state after CI is passed and all applicable checkboxes are closed.
This approach ensures that reviewers don't spend extra time asking for regular requirements.

You can remove a checkbox as not applicable only if it doesn't relate to this PR in any way.
For example, PR with docs update doesn't require checkboxes for performance while PR with any change in actual code should have checkboxes and justify how this code change is expected to affect performance (or justification should be self-evident).

Checklist to comply with before moving PR from draft:

PR completeness and readability

  • I have reviewed my changes thoroughly before submitting this pull request.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes or created a separate PR with update and provided its number in the description, if necessary.
  • Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
  • I have added a respective label(s) to PR if I have a permission for that.
  • I have resolved any merge conflicts that might occur with the base branch.

Testing

  • I have run it locally and tested the changes extensively.
  • All CI jobs are green or I have provided justification why they aren't.
  • I have extended testing suite if new functionality was introduced in this PR.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@icfaust
Copy link
Contributor

icfaust commented Nov 13, 2024

Anyone ever consider that "All CI jobs are green or I have provided justification why they aren't." is a perpetual loop?

@napetrov
Copy link
Contributor

Anyone ever consider that "All CI jobs are green or I have provided justification why they aren't." is a perpetual loop?

i would say it's

@napetrov napetrov closed this Nov 13, 2024
@napetrov napetrov reopened this Nov 13, 2024
@ethanglaser ethanglaser merged commit ebba880 into intel:main Nov 13, 2024
27 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants