Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hyperparameters): get_hyperparameters as staticmethod #2164

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

ahuber21
Copy link
Contributor

@ahuber21 ahuber21 commented Nov 13, 2024

Description

Changes the get_hyperparameter() method to act like a @staticmethod.
For a better user experience, the code was modified to additionally raise a Warning if called on an instance.
This should help avoid confusion about the singleton hyperparameters.

>>> from sklearnex.ensemble import RandomForestClassifier
>>> rf = RandomForestClassifier(max_depth=2)
>>> rf.get_hyperparameters("infer")
.../sklearnex/_utils.py:114: UserWarning: Hyperparameters are static variables and can not be modified per instance.
  warnings.warn(
<onedal.common.hyperparameters.HyperParameters object at 0x71dccbfb0130>
>>> RandomForestClassifier.get_hyperparameters("infer")
<onedal.common.hyperparameters.HyperParameters object at 0x71dccbfb0130>

PR should start as a draft, then move to ready for review state after CI is passed and all applicable checkboxes are closed.
This approach ensures that reviewers don't spend extra time asking for regular requirements.

You can remove a checkbox as not applicable only if it doesn't relate to this PR in any way.
For example, PR with docs update doesn't require checkboxes for performance while PR with any change in actual code should have checkboxes and justify how this code change is expected to affect performance (or justification should be self-evident).

Checklist to comply with before moving PR from draft:

PR completeness and readability

  • I have reviewed my changes thoroughly before submitting this pull request.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes or created a separate PR with update and provided its number in the description, if necessary.
  • Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
  • I have added a respective label(s) to PR if I have a permission for that.
  • I have resolved any merge conflicts that might occur with the base branch.

Testing

  • I have run it locally and tested the changes extensively.
  • All CI jobs are green or I have provided justification why they aren't.
  • I have extended testing suite if new functionality was introduced in this PR.

Performance

  • I have measured performance for affected algorithms using scikit-learn_bench and provided at least summary table with measured data, if performance change is expected.
  • I have provided justification why performance has changed or why changes are not expected.
  • I have provided justification why quality metrics have changed or why changes are not expected.
  • I have extended benchmarking suite and provided corresponding scikit-learn_bench PR if new measurable functionality was introduced in this PR.

@ahuber21 ahuber21 changed the title Dev/ahuber/refactor get hyperparameters staticmethod feat(hyperparameters): get_hyperparameters as staticmethod Nov 13, 2024
@ahuber21 ahuber21 marked this pull request as ready for review November 15, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant