-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add aten::index_reduce operator #1156
Conversation
cfgfung
commented
Dec 11, 2024
•
edited by xytintel
Loading
edited by xytintel
- index_reduce.out
- index_reduce
- index_reduce_
Synced with @xytintel , the difference is small. Will skip those 3 cases. e.g: |
Implemented the index_reduce, index_reduce_ and index_reduce.out operators. It passes most of the unit tests on the PVC platform except 3 tests. Those failed tests are bf16 and float16. I checked the differences and found those are small. For example:
I suspect the software emulation of the atomic operations of those low-level precisions causes that. Shall we skip those tests? Need inputs from @xytintel and @fengyuan14 Side note: This function is in beta and may change in the near future. (Ref - https://pytorch.org/docs/stable/generated/torch.Tensor.index_reduce_.html) |