[FEATURE] Perform Data Analytics on Output Generated JSON #8 #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Analysing JSON data from 2 different ROM images in the form of Pie chart and bar graph view of various parameters. This implementation allows us to see comparative analysis of 2 binary files. With the help of pie chart and bar graphs, we can analyze various components of section types and file types. Implementation for intel#8 Signed-off-by: Kumar, Shubham <shubham.k@intel.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| exit() | ||
|
|
||
| # Opening 1st JSON file | ||
| first_file = open(sys.argv[1]) |
Check warning
Code scanning / CodeQL
File is not always closed
| # Opening 1st JSON file | ||
| first_file = open(sys.argv[1]) | ||
| # Opening 2nd JSON file | ||
| second_file = open(sys.argv[2]) |
Check warning
Code scanning / CodeQL
File is not always closed
gahan9
reviewed
Apr 27, 2023
| count_filetype_fv.append(list_file_type[0].count(search_key_filetype_fv)) | ||
|
|
||
| if count_filetype_driver[0] > 0: | ||
| print(f'{count_filetype_driver[0]} occurences of {search_key_filetype_driver} in {sys.argv[1]}') |
There was a problem hiding this comment.
It's better to use argument parser module instead of manually parsing arguments.
Also if given more preference to Function API... it'll be more scalable solution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Analysing JSON data from 2 different ROM images in the form of Pie chart and bar graph view of various parameters.
This implementation allows us to see comparative analysis of 2 binary files. With the help of pie chart and bar graphs, we can analyze various components of section types and file types.
Implementation for #8