Uefi support #23
Closed
Uefi support #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
function on uefi shell.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -12,10 +12,12 @@ | |||
|
|
|||
| __all__ = ["CommonCliAccess"] | |||
|
|
|||
| MAX_READ_SIZE = 0x400 | |||
Check notice
Code scanning / CodeQL
Unused global variable Note
|
|
||
| def validate_xmlcli_request(self): | ||
| clb.InitInterface() | ||
| status = 1 |
Check warning
Code scanning / CodeQL
Variable defined multiple times Warning
|
|
||
| with open(filename, 'rb') as in_file: # opening for [r]eading as [b]inary | ||
| data = in_file.read() # if you only wanted to read 512 bytes, do .read(512) | ||
| size = len(data) |
Check notice
Code scanning / CodeQL
Unused local variable Note
|
it needs additional work from xmlcli code base hence closing it for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to add support for UEFI based use cases in XmlCli.
It makes use of the Python UEFI interpreter available in edk2-libc open source project.