Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from circleCI to github actions #670

Merged
merged 3 commits into from
Jan 22, 2021
Merged

Switch from circleCI to github actions #670

merged 3 commits into from
Jan 22, 2021

Conversation

pradovic
Copy link
Collaborator

@pradovic pradovic commented Jan 20, 2021

This PR is switching build and test-md steps from circleci to github actions. These steps are run on pushes and PRs.
The release part is deprecated since it is not suppored by the current plan, and it will be switched to gh actions in the separate PR.

Part of #669.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@pradovic pradovic marked this pull request as draft January 20, 2021 15:03
@pradovic pradovic closed this Jan 20, 2021
@pradovic
Copy link
Collaborator Author

I was reverting some unnecessary changes that were covered by the different PRs and accidentally closed the PR. I am reoping it now as draft to continue working on github actions.

@pradovic pradovic reopened this Jan 20, 2021
@pradovic pradovic marked this pull request as ready for review January 22, 2021 11:33
Copy link
Collaborator

@koivunej koivunej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good. As usual, I don't think we should do the 24h grace period for CI stuff.

@koivunej koivunej merged commit dec261f into interledger:master Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants