-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker releases on gh actions #675
Conversation
This comment has been minimized.
This comment has been minimized.
I noticed as well, which was weird as I did not change any code in the repo. Also, some of other tests failed on a fork, so it might be that gh was slow last night. I will re-run to test what happens |
Yup, now all failed tests passed here, and also on my private repos/forks. It seems to be that there were some connection errors on gh instrances last night. |
.github/workflows/testdocker.yml
Outdated
username: ${{ secrets.DOCKER_HUB_USERNAME }} | ||
password: ${{ secrets.DOCKER_HUB_ACCESS_TOKEN }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we found out, part of the normal protective measures is that PRs cannot access secrets in any way. This was from https://docs.github.com/en/actions/reference/encrypted-secrets#using-encrypted-secrets-in-a-workflow which is referred from https://github.com/imjohnbo/ok-to-test#about.
As this PR cannot really be tested as a PR (see #675 (comment)), so only following the merge we can see if these work or not. I am thinking this doesn't really require a 24h period since either the docker push will work or it'll fail, but it doesn't really concern the code quality as there are no software changes. The previous |
Just to add a bit more clarification. This is going to be a dry-run and merging this will test the credentials and building process. If everything goes well, another PR with just changing |
Docker releases that mimic the same behavior as before. Docker releases are triggered on:
ilp-node-|ilp-cli-
prefixTag is derived same as before, using the same scripts.
This is only the dry-run and will not push images to dockerhub.
Cc: #678
Cc: #669