Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker releases on gh actions #675

Merged
merged 2 commits into from
Feb 2, 2021
Merged

Docker releases on gh actions #675

merged 2 commits into from
Feb 2, 2021

Conversation

pradovic
Copy link
Collaborator

@pradovic pradovic commented Feb 1, 2021

Docker releases that mimic the same behavior as before. Docker releases are triggered on:

  • push to master
  • tag on any branch with ilp-node-|ilp-cli- prefix

Tag is derived same as before, using the same scripts.
This is only the dry-run and will not push images to dockerhub.

Cc: #678
Cc: #669

@pradovic pradovic changed the title ci: test docker releases on gh actions Docker releases on gh actions Feb 1, 2021
@koivunej

This comment has been minimized.

@pradovic
Copy link
Collaborator Author

pradovic commented Feb 2, 2021

Test failure at https://github.com/interledger-rs/interledger-rs/pull/675/checks?check_run_id=1810927961#step:5:1107

I noticed as well, which was weird as I did not change any code in the repo. Also, some of other tests failed on a fork, so it might be that gh was slow last night. I will re-run to test what happens

@pradovic
Copy link
Collaborator Author

pradovic commented Feb 2, 2021

Test failure at https://github.com/interledger-rs/interledger-rs/pull/675/checks?check_run_id=1810927961#step:5:1107

Yup, now all failed tests passed here, and also on my private repos/forks. It seems to be that there were some connection errors on gh instrances last night.

Comment on lines 13 to 14
username: ${{ secrets.DOCKER_HUB_USERNAME }}
password: ${{ secrets.DOCKER_HUB_ACCESS_TOKEN }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we found out, part of the normal protective measures is that PRs cannot access secrets in any way. This was from https://docs.github.com/en/actions/reference/encrypted-secrets#using-encrypted-secrets-in-a-workflow which is referred from https://github.com/imjohnbo/ok-to-test#about.

@pradovic pradovic marked this pull request as ready for review February 2, 2021 14:28
@koivunej
Copy link
Collaborator

koivunej commented Feb 2, 2021

As this PR cannot really be tested as a PR (see #675 (comment)), so only following the merge we can see if these work or not. I am thinking this doesn't really require a 24h period since either the docker push will work or it'll fail, but it doesn't really concern the code quality as there are no software changes. The previous latest image is already quite old, so in the best case this will refresh it.

@pradovic
Copy link
Collaborator Author

pradovic commented Feb 2, 2021

As this PR cannot really be tested as a PR (see #675 (comment)), so only following the merge we can see if these work or not. I am thinking this doesn't really require a 24h period since either the docker push will work or it'll fail, but it doesn't really concern the code quality as there are no software changes. The previous latest image is already quite old, so in the best case this will refresh it.

Just to add a bit more clarification. This is going to be a dry-run and merging this will test the credentials and building process. If everything goes well, another PR with just changing push=true would make it push to a dockerhub.

@pradovic pradovic merged commit a5b551d into interledger:master Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants