Stream fuzzing fixes #715
Merged
Stream fuzzing fixes #715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koivunej
reviewed
May 3, 2021
| } | ||
|
|
||
| Ok(buffer_unencrypted) | ||
| } | ||
| } | ||
|
|
||
| impl<'a> Iterator for FrameIterator<'a> { | ||
| type Item = Frame<'a>; |
There was a problem hiding this comment.
I think this could even be:
type Item = Result<Frame<'a>, WhateverTheErrorIs>;
And instead of returning a FrameIterator from StreamPacket::frames() we could return a impl Iterator<Item = Frame<'a>> which would be constructed from FrameIterator { ... }.map(|res| res.expect("checked at parsing time")).
This would however require some state in the FrameIterator to return None after the first Err return value.
However this isn't something that should be handled right away, perhaps polish at the end if anything.
koivunej
reviewed
May 3, 2021
koivunej
reviewed
May 3, 2021
whalelephant
force-pushed
the
stream-fuzz-iter_frames
branch
from
ab1bed9
to
d290f4b
Compare
whalelephant
force-pushed
the
stream-fuzz-iter_frames
branch
from
d290f4b
to
7b01969
Compare
koivunej
reviewed
May 4, 2021
koivunej
approved these changes
May 4, 2021
Signed-off-by: bwty <whalelephant@users.noreply.github.com>
Signed-off-by: bwty <whalelephant@users.noreply.github.com>
Signed-off-by: bwty <whalelephant@users.noreply.github.com>
Co-authored-by: Joonas Koivunen <joonas.koivunen@gmail.com> Signed-off-by: bwty <whalelephant@users.noreply.github.com>
Signed-off-by: bwty <whalelephant@users.noreply.github.com>
Co-authored-by: Joonas Koivunen <joonas.koivunen@gmail.com>
whalelephant
force-pushed
the
stream-fuzz-iter_frames
branch
from
eb38cf4
to
a691723
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc: #705
Focused on fuzzing
StreamPacketTODO: