Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PB-1482]: feat/compatibility-with-mongo-db-to-4.4 #159

Merged
merged 32 commits into from
Jan 19, 2024

Conversation

sw-wayner
Copy link

@sw-wayner sw-wayner commented Jan 5, 2024

Add end-to-end tests (e2e)

In order to upgrade mongo from version 3.6 to 4.4, e2e tests where added to ensure the main features work fine

Used strategy

  1. Add supertest package
  2. Add configuration for e2e testing
  3. Add e2e tests to cover:
    • Upload/download/share/delete files
    • Create/Update/Delete buckets
    • Create/Update/Delete users

Note

Related task: PB-1482

@sw-wayner sw-wayner changed the title [_]; feat/upgrade-network-mongo-db [_]: feat/upgrade-network-mongo-db Jan 5, 2024
@sg-gs
Copy link
Member

sg-gs commented Jan 8, 2024

Do not count with #120 @sw-wayner. The code could be useful for this PR, but it is not updated to the actual codebase, so assume everything would be packed here. We will close that PR for being stalled soon.

tests/lib/e2e/utils.ts Outdated Show resolved Hide resolved
infrastructure/mongo-init.js Show resolved Hide resolved
tests/lib/e2e/e2e-spec.ts Outdated Show resolved Hide resolved
@sg-gs sg-gs added the enhancement New feature or request label Jan 8, 2024
lib/server/http/users/controller.ts Outdated Show resolved Hide resolved
tests/lib/e2e/users.fixtures.ts Outdated Show resolved Hide resolved
tests/lib/e2e/users/users.e2e-spec.ts Outdated Show resolved Hide resolved
tests/lib/e2e/buckets/buckets.e2e-spec.ts Outdated Show resolved Hide resolved
tests/lib/e2e/buckets/buckets.e2e-spec.ts Outdated Show resolved Hide resolved
tests/lib/e2e/buckets/buckets.e2e-spec.ts Outdated Show resolved Hide resolved
tests/lib/e2e/buckets/buckets.e2e-spec.ts Outdated Show resolved Hide resolved
tests/lib/e2e/buckets/buckets.e2e-spec.ts Outdated Show resolved Hide resolved
tests/lib/e2e/users/users.e2e-spec.ts Outdated Show resolved Hide resolved
tests/lib/e2e/users/users.e2e-spec.ts Outdated Show resolved Hide resolved
tests/lib/e2e/users/users.e2e-spec.ts Outdated Show resolved Hide resolved
tests/lib/e2e/utils.ts Outdated Show resolved Hide resolved
tests/lib/e2e/utils.ts Outdated Show resolved Hide resolved
@sw-wayner sw-wayner changed the title [_]: feat/upgrade-network-mongo-db [PB-1482]: feat/upgrade-network-mongo-db Jan 11, 2024
@sw-wayner sw-wayner marked this pull request as ready for review January 12, 2024 14:38
@sw-wayner sw-wayner changed the title [PB-1482]: feat/upgrade-network-mongo-db [PB-1482]: feat/upgrade-network-mongo-db-to-4.4 Jan 12, 2024
tests/lib/e2e/buckets/files.e2e-spec.ts Outdated Show resolved Hide resolved
tests/lib/e2e/buckets/files.e2e-spec.ts Outdated Show resolved Hide resolved
tests/lib/e2e/buckets/files.e2e-spec.ts Outdated Show resolved Hide resolved
tests/lib/e2e/buckets/files.e2e-spec.ts Outdated Show resolved Hide resolved
tests/lib/e2e/buckets/files.e2e-spec.ts Outdated Show resolved Hide resolved
tests/lib/e2e/buckets/files.e2e-spec.ts Outdated Show resolved Hide resolved
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions

1.1% Coverage on New Code (required ≥ 80%)
5.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@sg-gs sg-gs changed the title [PB-1482]: feat/upgrade-network-mongo-db-to-4.4 [PB-1482]: feat/compatibility-with-mongo-db-to-4.4 Jan 19, 2024
@sg-gs
Copy link
Member

sg-gs commented Jan 19, 2024

Great work @sw-wayner

@sg-gs sg-gs merged commit 083dd09 into master Jan 19, 2024
3 of 4 checks passed
@sg-gs sg-gs deleted the feat/upgrade-network-mongo-db branch January 19, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants