Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it easier to add namespace from same server to workspace #1232

Merged

Conversation

gjsjohnmurray
Copy link
Contributor

When using the Explorer context menu on a folder in an isfs workspace to add another root, make it easier to pick another namespace on the same server as the current root.

image

@isc-bsaviano
Copy link
Contributor

I'm not seeing the benefit. It doesn't reduce prompts for the case where you want to use the same server, and it adds a prompt for the other case. The server list prompt can be filtered by typing so even if you have a huge server list it's easy to get to the one you want.

@gjsjohnmurray
Copy link
Contributor Author

It doesn't reduce prompts for the case where you want to use the same server

It almost always reduces keystrokes for that case, the exception being when the desired server is first in your list, in which case you use the same number of keystrokes as before.

Yes, long server lists can be filtered but it seems unhelpful not to have a quick path for the "another namespace on this same server" case.

Yes, it adds 2 keystrokes to the other path.

Copy link
Contributor

@isc-bsaviano isc-bsaviano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your comment makes sense.

@gjsjohnmurray gjsjohnmurray merged commit 48d9a0f into intersystems-community:master Sep 18, 2023
7 checks passed
@gjsjohnmurray gjsjohnmurray deleted the amaranth-elephant branch September 18, 2023 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants