Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support setting data breakpoints on subsequent debug sessions (fix #1251) #1252

Merged
merged 2 commits into from
Oct 16, 2023

Conversation

gjsjohnmurray
Copy link
Contributor

This PR fixes #1251

@gjsjohnmurray
Copy link
Contributor Author

@isc-solon @isc-rsingh please download the zip at https://github.com/intersystems-community/vscode-objectscript/suites/17213418630/artifacts/983708130 and extract the dev VSIX it contains, then install it and re-test setting data breakpoints.

@isc-solon
Copy link
Collaborator

Unfortunately, not fixed yet. I installed the vsix. Restarted VS Code. Added a breakpoint and clicked "Debug". A variable appeared in the VARIABLES section. When I right-clicked the variable, I saw "Break on value change" for the very first time! I didn't choose the option, however. I clicked "Step Over" button. Another variable appeared. But right-clicking doesn't offer the watchpoint option anymore for either variable. I added one of the variables to the WATCH section. Right-clicking the variable there also doesn't offer the watchpoint option.

@gjsjohnmurray
Copy link
Contributor Author

Please try this one.

https://github.com/intersystems-community/vscode-objectscript/suites/17267930228/artifacts/986402685

Filename is unchanged but this one should work properly. Note though that "Break on Value Change" will only show up on unsubscripted variables on the Variables view.

@isc-solon
Copy link
Collaborator

The latest fix worked. Thanks! But...right-clicking on a variable in the WATCH section doesn't offer the watchpoint option. Is it possible to add that to this fix?

@gjsjohnmurray
Copy link
Contributor Author

VS Code doesn't support setting data breakpoints from the Watch view, presumably because entries there are expressions.

@gjsjohnmurray
Copy link
Contributor Author

@isc-bsaviano please review and approve this.

@gjsjohnmurray gjsjohnmurray merged commit b759a83 into intersystems-community:master Oct 16, 2023
7 checks passed
@gjsjohnmurray gjsjohnmurray deleted the fix-1251 branch October 16, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data breakpoints (watchpoints) only settable on the first debug run
3 participants