-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set file readonly if class is deployed or if server-side source control reports it not editable #1399
Set file readonly if class is deployed or if server-side source control reports it not editable #1399
Conversation
Co-authored-by: Brett Saviano <bsaviano@intersystems.com>
Set as ready so a testable VSIX gets built. |
Thanks for making those changes |
Should I wait until that linked Pull Request is merged before I test/approve this? |
The issue the linked PR fixes is only likely to affect how this new feature behaves with Deltanji's server-side source control class, because of how when we cancel a checkout we reset the mtime of the document to that of the reinstated version. Please go ahead and review it. |
@gjsjohnmurray I installed the dev VSIX and it appears to work as designed. However, the new setting is showing up as an "unknown configuration setting" in the JSON and doesn't appear in the UI. The setting is respected if it's manually added to the JSON though. Also, you don't need to add the explicit default values for the boolean settings within vscode-objectscript/package.json Lines 1334 to 1347 in c426c7a
|
I pushed a change to remove those defaults. As for the settings problem, I haven't been able to reproduce this. The setting displays for me in Settings Editor, and when present in JSON it's not marked / tipped as having a problem. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gjsjohnmurray I installed the latest dev vsix and everything looks good. Thanks for this PR!
This PR closes #1397
In some circumstances the current VS Code (1.91.1) doesn't correctly switch an editor to be readonly. My PR microsoft/vscode#221023 will resolve this. Meanwhile I am creating this PR as a Draft.