-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Client-side editing overhaul #1401
Draft
isc-bsaviano
wants to merge
12
commits into
intersystems-community:master
Choose a base branch
from
isc-bsaviano:fix-1278
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Client-side editing overhaul #1401
isc-bsaviano
wants to merge
12
commits into
intersystems-community:master
from
isc-bsaviano:fix-1278
+2,928
−6,484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@gjsjohnmurray @isc-rsingh I've opened this as a draft since this is a giant PR that needs thorough review. I have a few design questions for you that I'd like to resolve before formally starting the review process and seeking feedback from other users:
|
@daimor I'd appreciate your feedback on this as a regular client-side editing user. |
Is this worth publicizing on DC for feedback before merging? |
This was referenced Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isfs
virtual workspaces for client-side editing #1278.Uri
s as the value, and one in the reverse direction.FileSystemWatcher
to update the index when files are created, deleted or changed on disk and anonDidChangeTextDocument
handler to update the index when a file is changed within VS Code.Uri
for it in a workspace folder was deleted.DocumentContentProvider.getUri()
will use the index to determine theUri
for a class or routine in a non-isfs folder. The export settings are now only used for non-classes and routines in folders with thefile
scheme.WorkspaceSymbolProvider
will only return results from classes that are in the client-side folder by using the index to determine all known classes.objectscript.showExplorer
setting.objectscript.export
settings, except for DFI’s which still check the export settings to preserve the path splitting behavior added by Improve client-side DFI workflow #808. Any file within a workspace folder that has a supported abstract document extension will be imported with the last part of the path used as the server name (except for DFI’s that match the export settings).Add Server Namespace to Workspace…
command if the current workspace already has a client-side folder in it. This is to prevent the blending of client-side and server-side workflows in a way that can lead to lost changes or overwritten edits.objectscript.explorer.alwaysShowServerCopy
setting to true. The InterSystems Explorer should always show the server copy since the local copy can be opened from the files explorer.objectscript.export.noStorage
setting. Storage is an integral part of the class definition, and we shouldn’t allow removing it.objectscript.export.dontExportIfNoChanges
setting. I don’t think that turning it on adds any benefit to the user.