Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix showing of CSP files in project folders #1408

Merged
merged 2 commits into from
Jul 24, 2024

Conversation

isc-bsaviano
Copy link
Contributor

This PR fixes #1406 and fixes #1407

@isc-bsaviano
Copy link
Contributor Author

@gjsjohnmurray Everything looks fine to me now. Please let me know if you're still seeing issues.

@gjsjohnmurray
Copy link
Contributor

My Show1407 project now expands correctly in Explorer view.

However the second part of my procedure at #1407 (comment) (creation of New1407 project) still results in an incorrect project definition. The XML export of it looks like this:

<?xml version="1.0" encoding="UTF-8"?>
<Export generator="IRIS" version="26" zv="IRIS for Windows (x86-64) 2024.1 (Build 267_2U)" ts="2024-07-24 15:25:48">
<Project name="New1407" LastModified="2024-07-24 15:23:58">
  <Items>
    <ProjectItem name="show1407" type="PKG"></ProjectItem>
  </Items>
</Project>
</Export>

It seems that the Add Items to Project... step incorrectly creates a ProjectItem of type PKG when I selected the folder named show1407. Notice that the name attribute of the bad ProjectItem is lowercase, which is why our VS Code views fail to expand the classes that are in the Show1407 package.

@isc-bsaviano
Copy link
Contributor Author

Should be good now

@isc-bsaviano isc-bsaviano merged commit 18d805b into intersystems-community:master Jul 24, 2024
5 checks passed
@isc-bsaviano isc-bsaviano deleted the fix-1407 branch July 24, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants