Node highlighting addition to previous pull request #1348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. Removed unrelated border option crashing.
…ode color not reset after selecting another node, highlighting also when changing constraint sliders, change node color instead of border, added menu options to change color (added to settings).
|
Did some refactors and fixed this issue (highlighting not reset after changing node): Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry about the messy code in my previous PR. We have made multiple changes to Rtabmap over the last few years (often in a very hacky fashion), and I am trying to clean up and create pull requests for some of that code. However, as you noted, I inadvertently managed to grab a couple of pieces of code unrelated to the feature I was trying to share with you in the last PR. I appreciate your willingness to work with me anyway. I really like how it turned out, and I will try to be more careful in the future.
Along those lines, here is some code to properly highlight the graph poses that are currently selected.