Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node highlighting addition to previous pull request #1348

Merged
merged 9 commits into from
Sep 29, 2024

Conversation

Nosille
Copy link
Contributor

@Nosille Nosille commented Sep 23, 2024

Sorry about the messy code in my previous PR. We have made multiple changes to Rtabmap over the last few years (often in a very hacky fashion), and I am trying to clean up and create pull requests for some of that code. However, as you noted, I inadvertently managed to grab a couple of pieces of code unrelated to the feature I was trying to share with you in the last PR. I appreciate your willingness to work with me anyway. I really like how it turned out, and I will try to be more careful in the future.

Along those lines, here is some code to properly highlight the graph poses that are currently selected.

@matlabbe
Copy link
Member

matlabbe commented Sep 29, 2024

Did some refactors and fixed this issue (highlighting not reset after changing node):
Screenshot from 2024-09-28 10-21-59

Thanks again!

@matlabbe matlabbe merged commit 538bc68 into introlab:master Sep 29, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants