Merge pull request #36 from invenia/bc/argument-error-fix

Fix and test ArgumentError for nonexistant dir
invenia · Oct 13, 2021 · 72299dd · 72299dd · bencottier · Oct 13, 2021
2 parents 9e0b661 + 21cde53
commit 72299dd
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/Project.toml b/Project.toml
@@ -1,7 +1,7 @@
 name = "Checkpoints"
 uuid = "b4a3413d-e481-5afc-88ff-bdfbd6a50dce"
 authors = "Invenia Technical Computing Corporation"
-version = "0.3.13"
+version = "0.3.14"
 
 [deps]
 AWSS3 = "1c724243-ef5b-51ab-93f4-b0a88ac62a95"

diff --git a/src/indexing.jl b/src/indexing.jl
@@ -138,7 +138,7 @@ You can also work with it directly, say you wanted to get all checkpoints files
 2: https://github.com/JuliaData/DataFrames.jl
 """
 function index_checkpoint_files(dir::AbstractPath)
-    isdir(dir) || throw(ArgumentError(dir, "Need an existing directory."))
+    isdir(dir) || throw(ArgumentError("Need an existing directory."))
     map(Iterators.filter(==("jlso") ∘ extension, walkpath(dir))) do checkpoint_path
         return IndexEntry(checkpoint_path)
     end

diff --git a/test/indexing.jl b/test/indexing.jl
@@ -53,4 +53,8 @@
             @test_throws ErrorException entry.tags
         end
     end
+
+    @testset "nonexistent dir" begin
+        @test_throws ArgumentError index_checkpoint_files("nonexistent_dir")
+    end
 end