Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Job details view #14

Merged
merged 24 commits into from
Jun 4, 2024
Merged

Conversation

carlinmack
Copy link
Contributor

@carlinmack carlinmack commented May 17, 2024

❤️ Thank you for your contribution!

Description

Please describe briefly your pull request.

image


image

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Frontend

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

render() {
const { jobId } = this.props;
const { title, description, config } = this.state;
return (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we miss a loader before the HTTP call finishes

Copy link
Contributor Author

@carlinmack carlinmack May 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the API call is progressively enhancing the UI, I think showing a loader would make the UI feel laggy and slower than necessary

For context before:
image

after:

image

(where the title and description are returned from the API)

@carlinmack carlinmack force-pushed the job-details branch 2 times, most recently from 275498f to fbfdbaa Compare May 30, 2024 14:48
Copy link
Member

@alejandromumo alejandromumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot :)

Left some comments, we can go through them IRL if you want

Plus changes requested by manuel
@alejandromumo alejandromumo merged commit 34f9c02 into inveniosoftware:master Jun 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jobs Administration UI
4 participants