-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Job details view #14
Conversation
invenio_jobs/assets/semantic-ui/js/invenio_jobs/administration/index.js
Outdated
Show resolved
Hide resolved
5ef0044
to
a3da607
Compare
...o_jobs/assets/semantic-ui/js/invenio_jobs/administration/search/JobSearchResultItemLayout.js
Outdated
Show resolved
Hide resolved
invenio_jobs/assets/semantic-ui/js/invenio_jobs/administration/search/JobRunsHeader.js
Outdated
Show resolved
Hide resolved
render() { | ||
const { jobId } = this.props; | ||
const { title, description, config } = this.state; | ||
return ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we miss a loader before the HTTP call finishes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
invenio_jobs/assets/semantic-ui/js/invenio_jobs/administration/search/JobRunsHeader.js
Outdated
Show resolved
Hide resolved
275498f
to
fbfdbaa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot :)
Left some comments, we can go through them IRL if you want
invenio_jobs/assets/semantic-ui/js/invenio_jobs/administration/JobRuns.js
Show resolved
Hide resolved
invenio_jobs/assets/semantic-ui/js/invenio_jobs/administration/JobRunsHeader.js
Outdated
Show resolved
Hide resolved
invenio_jobs/assets/semantic-ui/js/invenio_jobs/administration/JobRunsHeader.js
Outdated
Show resolved
Hide resolved
invenio_jobs/assets/semantic-ui/js/invenio_jobs/administration/JobSearchResultItemLayout.js
Show resolved
Hide resolved
invenio_jobs/assets/semantic-ui/js/invenio_jobs/administration/JobSearchResultItemLayout.js
Outdated
Show resolved
Hide resolved
invenio_jobs/assets/semantic-ui/js/invenio_jobs/administration/RunButton.js
Show resolved
Hide resolved
invenio_jobs/assets/semantic-ui/js/invenio_jobs/administration/RunsSearchResultItemLayout.js
Outdated
Show resolved
Hide resolved
invenio_jobs/assets/semantic-ui/js/invenio_jobs/administration/StatusFormatter.js
Outdated
Show resolved
Hide resolved
invenio_jobs/assets/semantic-ui/js/invenio_jobs/administration/StopButton.js
Outdated
Show resolved
Hide resolved
invenio_jobs/assets/semantic-ui/js/invenio_jobs/administration/api.js
Outdated
Show resolved
Hide resolved
Plus changes requested by manuel
❤️ Thank you for your contribution!
Description
Checklist
Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:
Frontend
Reminder
By using GitHub, you have already agreed to the GitHub’s Terms of Service including that: