-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
job: refactor args #60
Conversation
071c3cb
to
0696cdb
Compare
@@ -101,31 +101,24 @@ class SearchResultItemComponent extends Component { | |||
/> | |||
</> | |||
) : ( | |||
"−" | |||
"-" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was there something wrong 👀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it was some weird char instead of -
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was intentionally chosen as normal n-dashes look too short: -
I prefer an em-dash: —
But went with one in between to be a bit fancy: −
Unless there is a problem with the character not displaying I don't see why not choose something that looks better
acabc52
to
4d562d1
Compare
* adds PredefinedArgsSchema schema class with predefined args, including `since`. * changes JobType public/private interface to make it easier to define your own job types * logs celery tasks error message and shows it in the UI * removes unused code
4d562d1
to
7d0a904
Compare
since
.your own job types