UI testing: issues

[FlorianCassayre]

Backoffice

• Any form that uses a "search document/location" component:

  • When no result is found the dropdown stays visible, even when the field loses focus. Actually the only way to get rid of the message is to make a selection. (fixed by Backoffice: fix HitsSearch component #217)
  • The auto-completion does not work as the user intends it to: it expects full keywords rather than just prefixes (fixed by Backoffice: fix HitsSearch component #217)

• Document/Series/Item/... forms:

  • No error message is displayed if the server is down (see also Fix error and success messages invenio-app-ils#855) (fixed by Forms: improved submission and errors #220)
  • The error tooltip on fields is displayed on top, messing the alignment (see tooltip alignment in form validation #169)
  • The price field does not match the server schema (see PriceField component - Fix validation #155)
  • The "Navigation" menu does not have an initial value before scrolling (fixed by Minor bugfixes #180)
  • Some elements define a "tabindex"="0" and are initially focused, but actually appear in the middle of the page (fixed by Minor bugfixes #180)
  • Frontend error when viewing the page from a mobile device (fixed by Minor bugfixes #180)
  • The cross icon (keywords, authors, ...) appears on top of everything else, including an expanded dropdown(fixed by forms: fix delete button overlap with dropdown #216)

• Search:

  • Search result exportation doesn't work (fixed by Minor bugfixes #180)

• Document search:

  • When clicking on a tag (Drama, Thriller, etc.), the url is updated but nothing happens unless the page is reloaded (see Search: issues with history #196)
  • Start with an empty search, click on a tag, and go back a page: the search provides an empty result set (again, unless if the page is reloaded) (see Search: issues with history #196)

• Document:

  • In the "Request loan for a patron" modal, the "Request" button is not disabled when no patron is provided (fixed by Minor bugfixes #180)
  • When in document details, the button Request loan for Patron in DocumentActionMenu, throws an error: locationPid is marked as required in LocationDatePicker, but its value is null. The input for the date is disabled until we select a patron with a locationPid, maybe we can prevent rendering the calendar until we have a locationPid(fixed by forms: fix delete button overlap with dropdown #216)

• Loans:

  • Frontsite error after clicking on the "Replace" button (trace) (fixed by Minor bugfixes #180)
  • "Send return reminder", is not working for overdue loans (it returns a 400 saying "This loan is not overdue") (see Send return reminder broken #204)

• Item:

  • The checkout buttons are in loading state but not disabled, they can still be clicked and will throw errors (I believe it is my fault) (fixed by Minor bugfixes #180)
  • A malicious librarian can leave the database/index in an inconsistent state by allocating two distinct loans the same item. This can be reproduced by opening the page on two different tabs, and rapidly clicking on the two checkout buttons. After that the server detects the inconsistency (MultipleLoansOnItemError) but cannot recover from it (see Ensure item is not already on loan when doing a checkout invenio-circulation#120)

• Series:

  • On the edition/creation form, the author component has performance issues when typing in it. This comes from a more general problem that affects all <StringField /> components due to a slow onChange method handler (see Backoffice: text input latency issues #218)

• ILL:

  • Borrowing request modal (button "New loan"): select an end date, the "Create" button should enable, close the modal and reopen it; the "Create" button is still enabled despite no end date being selected (fixed by Minor bugfixes #180)

• Patrons:

  • ILL in patron profile is not displayed correctly (consider split the title in 2 lines). (fixed by backoffice: Fixes ILL section in patron details page #215)

    

• Overview:

  • Button "Send reminder" is not disabled if the loan is not overdue. Same problem on the loan page, but with no error feedback this time (see Send return reminder broken #204)

Frontsite

• Search

  • When performing a global search from the homepage, the pagination does not show any page to be selected. After that, when clicking on "1" to select the first page the result changes (see Search: issues with history #196)

  • Error message is not correctly aligned when getting 429 errors (too many requests).

    

• Patron profile ("My loans"):
  • Superfluous navigation buttons when there is clearly zero entries (fixed by Minor bugfixes #180)
• Document/series page:
  • The frontend raises an error if the server is down (reason is that error.response is not necessarily set) (fixed by Add keywords and tags to series #179)
• Login page:
  • The dimmer only prevents the user from interacting with the input using their mouse, but not with their keyboard (ie. typing stuff) (see also [Form] - .loading.form doesn't prevent selecting controls by tabbing Semantic-Org/Semantic-UI#3664) (fixed by Forms: improved submission and errors #220)

Global

• When a query will not match anything in any of the search bars we render SearchEmptyResults. If we click on the "clear query" button; the input field in the SearchBar is not cleared (see Remove duplicate implementation of ReactSearchKit SearchBar #226)
• Inconsistencies with the sorting order and the sorting filters (for instance some have both "Title A-Z" and "Asc/Desc"). Moreover not all occurrences of "Asc/Desc" seem to work (e.g. the one on the frontsite series page) (fixed by ReactSearchKit: pass initial query state [DEPENDS ON inveniosoftware/react-searchkit#137] #214)
• The filters are not working as a user would expect. We can have multiple filters selected, for instance, we can select 2 different tags but we will only get the books that contain the last slected tag, instead of getting all the books with both tags (see Cannot search for multiple aggregations of the same category #219)
• 429 errors (too many requests) can be reached quickly when navigating on pages that perform multiple requests (current backend limitation is 100 requests per minute). Also there is no global handling of these errors as each component fail independently (see Request limit reached CERNDocumentServer/cds-ils#150)

If needed, please edit this issue and extract some bullets into separate tickets.