Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate implementation of ReactSearchKit SearchBar #226

Closed
32 of 33 tasks
topless opened this issue Oct 7, 2020 · 0 comments · Fixed by #233
Closed
32 of 33 tasks

Remove duplicate implementation of ReactSearchKit SearchBar #226

topless opened this issue Oct 7, 2020 · 0 comments · Fixed by #233
Assignees
@topless
Milestone
2020/W40

Comments

@topless
Copy link
Member

topless commented Oct 7, 2020 •
edited
Loading

Is your feature request related to a problem? Please describe.

In our SearchControlsOverrides we are swapping the SearchBar that comes from RSK, with our own implementation which is a copy of what RSK provides.

Describe the solution you'd like

We should override only the things needed, not re-implement everything, check related issue about redux state.

Additional context

Our current SearchBar has been mixed also with the queryHelpBuilder

Tested Components

QueryBuildHelper

It doesn't come attached with SearchBar, but as a stand alone component, use at will.

  • DocumentSearch
  • DocumentRequestSearch
  • EItemSearch
  • BorrowingRequestSearch
  • LibrarySearch
  • ItemSearch
  • LoanSearch
  • OrderSearch
  • PatronSearch
  • SeriesSearch
  • VendorSearch

SearchBar with react-searchkit (RSK)

Instead of overriding the SearchBar.element we just customise the SearchBar through props.

  • BorrowingRequestSearch
  • DocumentRequestSearch
  • DocumentSearch
  • EItemSearch
  • ItemSearch
  • LibrarySearch
  • LiteratureSearch
  • LoanSearch
  • OrderSearch
  • PatronSearch
  • SeriesLiteratureSearch
  • SeriesSearch
  • VendorSearch

SearchBar with redirect

SearchBar which redirects to a provided prop

  • HomeSearchBar
  • frontsite/Documents/DocumentDetails/DocumentDetails
  • frontiste/Series/SeriesDetails

ILS SearchBar

Custom SearchBar with additional functionality

  • CheckIn/ItemsSearch/ItemsSearch
  • CheckOut/CheckOutSearch/CheckOutSearch
  • Patron/PatronDetails/ItemsSearch/ItemsSearch
  • LoanDetails/AvailableItems/AvailableItems.js: Possibly create an issue about this one
    • is it needed? how much sense it makes? Since the loan request is on a document and we display its items, what are we searching for?
    • updateQueryString is not a function, also happens in deployed version

SearchControlsMobile

  • SeriesLiteratureSearchMobile
  • LiteratureSearchMobile

Depends on inveniosoftware/react-searchkit#141
@topless topless self-assigned this Oct 7, 2020
topless added a commit to topless/react-invenio-app-ils that referenced this issue Oct 7, 2020
@topless
components: SearchBar
2fa5532 
- upgrade react-searchkit 1.0.0-alpha.3
- removed buttonColor, never used, and in case we use it, it has no effect since its overridden by the .ui.input.action.ils-searchbar styles
- subtitle to SearchError as child
- simplified search message when empty results
- closes inveniosoftware#226
@topless topless mentioned this issue Oct 7, 2020
Closed
31 tasks
topless added a commit to topless/react-invenio-app-ils that referenced this issue Oct 7, 2020
@topless
components: SearchBar
5672e00 
- upgrade react-searchkit 1.0.0-alpha.3
- removed buttonColor, never used, and in case we use it, it has no effect since its overridden by the .ui.input.action.ils-searchbar styles
- subtitle to SearchError as child
- simplified search message when empty results
- closes inveniosoftware#226
topless added a commit to topless/react-invenio-app-ils that referenced this issue Oct 9, 2020
@topless
components: SearchBar
588f647 
- upgrade react-searchkit 1.0.0-alpha.3
- removed buttonColor, never used, and in case we use it, it has no effect since its overridden by the .ui.input.action.ils-searchbar styles
- subtitle to SearchError as child
- simplified search message when empty results
- closes inveniosoftware#226
topless added a commit to topless/react-invenio-app-ils that referenced this issue Oct 9, 2020
@topless
components: SearchBar refactor
3a15dc5 
- upgrade react-searchkit 1.0.0-alpha.3
- removed buttonColor, never used, and in case we use it, it has no effect since its overridden by the .ui.input.action.ils-searchbar styles
- subtitle to SearchError as child
- simplified search message when empty results
- Decoupled QueryBuildHelper to a stand alone component connected to RSK state
- fix bug in PatronResultList, when we had empty results, there were displayed two empty results message boxes
- remove RSK override
- configure with props React Search Kit Search bar
- SearchBarILS our simplified not connected to RSK searchbar
- fixed issue with configuration on BucketAggregations
- SearchBarILS replacing individual searchbars
- closes inveniosoftware#226
@topless topless mentioned this issue Oct 9, 2020
Merged
topless added a commit to topless/react-invenio-app-ils that referenced this issue Oct 9, 2020
@topless
components: SearchBar refactor
dff4fd8 
- upgrade react-searchkit 1.0.0-alpha.3
- removed buttonColor, never used, and in case we use it, it has no effect since its overridden by the .ui.input.action.ils-searchbar styles
- subtitle to SearchError as child
- simplified search message when empty results
- Decoupled QueryBuildHelper to a stand alone component connected to RSK state
- fix bug in PatronResultList, when we had empty results, there were displayed two empty results message boxes
- remove RSK override
- configure with props React Search Kit Search bar
- SearchBarILS our simplified not connected to RSK searchbar
- fixed issue with configuration on BucketAggregations
- SearchBarILS replacing individual searchbars
- closes inveniosoftware#226
topless added a commit to topless/react-invenio-app-ils that referenced this issue Oct 11, 2020
@topless
components: SearchBar refactor
f37c12e 
- upgrade react-searchkit 1.0.0-alpha.3
- removed buttonColor, never used, and in case we use it, it has no effect since its overridden by the .ui.input.action.ils-searchbar styles
- subtitle to SearchError as child
- simplified search message when empty results
- Decoupled QueryBuildHelper to a stand alone component connected to RSK state
- fix bug in PatronResultList, when we had empty results, there were displayed two empty results message boxes
- remove RSK override
- configure with props React Search Kit Search bar
- SearchBarILS our simplified not connected to RSK searchbar
- fixed issue with configuration on BucketAggregations
- SearchBarILS replacing individual searchbars
- fixed missing identifiers for all <Identifiers>
- fixed empty results in series literature mobile was disconnected from RSK
- depends on inveniosoftware/react-searchkit#141
- closes inveniosoftware#226
topless added a commit to topless/react-invenio-app-ils that referenced this issue Oct 12, 2020
@topless
components: SearchBar refactor
453978f 
- upgrade react-searchkit 1.0.0-alpha.3
- removed buttonColor, never used, and in case we use it, it has no effect since its overridden by the .ui.input.action.ils-searchbar styles
- subtitle to SearchError as child
- simplified search message when empty results
- Decoupled QueryBuildHelper to a stand alone component connected to RSK state
- fix bug in PatronResultList, when we had empty results, there were displayed two empty results message boxes
- remove RSK override
- configure with props React Search Kit Search bar
- SearchBarILS our simplified not connected to RSK searchbar
- fixed issue with configuration on BucketAggregations
- SearchBarILS replacing individual searchbars
- fixed missing identifiers for all <Identifiers>
- fixed empty results in series literature mobile was disconnected from RSK
- depends on inveniosoftware/react-searchkit#141
- closes inveniosoftware#226
topless added a commit to topless/react-invenio-app-ils that referenced this issue Oct 12, 2020
@topless
components: SearchBar refactor
43ccfe7 
- upgrade react-searchkit 1.0.0-alpha.3
- removed buttonColor, never used, and in case we use it, it has no effect since its overridden by the .ui.input.action.ils-searchbar styles
- subtitle to SearchError as child
- simplified search message when empty results
- Decoupled QueryBuildHelper to a stand alone component connected to RSK state
- fix bug in PatronResultList, when we had empty results, there were displayed two empty results message boxes
- remove RSK override
- configure with props React Search Kit Search bar
- SearchBarILS our simplified not connected to RSK searchbar
- fixed issue with configuration on BucketAggregations
- SearchBarILS replacing individual searchbars
- fixed missing identifiers for all <Identifiers>
- fixed empty results in series literature mobile was disconnected from RSK
- depends on inveniosoftware/react-searchkit#141
- closes inveniosoftware#226
topless added a commit to topless/react-invenio-app-ils that referenced this issue Oct 13, 2020
@topless
components: SearchBar refactor
534a666 
- upgrade react-searchkit 1.0.0-alpha.3
- removed buttonColor, never used, and in case we use it, it has no effect since its overridden by the .ui.input.action.ils-searchbar styles
- subtitle to SearchError as child
- simplified search message when empty results
- Decoupled QueryBuildHelper to a stand alone component connected to RSK state
- fix bug in PatronResultList, when we had empty results, there were displayed two empty results message boxes
- remove RSK override
- configure with props React Search Kit Search bar
- SearchBarILS our simplified not connected to RSK searchbar
- fixed issue with configuration on BucketAggregations
- SearchBarILS replacing individual searchbars
- fixed missing identifiers for all <Identifiers>
- fixed empty results in series literature mobile was disconnected from RSK
- depends on inveniosoftware/react-searchkit#141
- closes inveniosoftware#226
ntarocco pushed a commit that referenced this issue Oct 13, 2020
@topless @ntarocco
components: SearchBar refactor
75f1faf 
- upgrade react-searchkit 1.0.0-alpha.3
- removed buttonColor, never used, and in case we use it, it has no effect since its overridden by the .ui.input.action.ils-searchbar styles
- subtitle to SearchError as child
- simplified search message when empty results
- Decoupled QueryBuildHelper to a stand alone component connected to RSK state
- fix bug in PatronResultList, when we had empty results, there were displayed two empty results message boxes
- remove RSK override
- configure with props React Search Kit Search bar
- SearchBarILS our simplified not connected to RSK searchbar
- fixed issue with configuration on BucketAggregations
- SearchBarILS replacing individual searchbars
- fixed missing identifiers for all <Identifiers>
- fixed empty results in series literature mobile was disconnected from RSK
- depends on inveniosoftware/react-searchkit#141
- closes #226
@kpsherva kpsherva added this to the 2020/W40 milestone Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@topless topless

Labels
None yet
Projects
None yet
Milestone
2020/W40
Development

Successfully merging a pull request may close this issue.

components: SearchBar refactor topless/react-invenio-app-ils
2 participants
@topless @kpsherva