Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add missing createChannels mock. #1123

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

NathanP-7West
Copy link
Contributor

@NathanP-7West NathanP-7West commented Oct 15, 2024

Hi there,

Just a minor addition to the jest-mock for the react-native package.
The createChannels method was missing a mock implementation, which was a bit of a head-scratcher in tests until I tracked it down to here.

Cheers.

@CLAassistant
Copy link

CLAassistant commented Oct 15, 2024

CLA assistant check
All committers have signed the CLA.

@NathanP-7West NathanP-7West changed the title Add missing createChannels mock. (fix) Add missing createChannels mock. Oct 15, 2024
@NathanP-7West NathanP-7West changed the title (fix) Add missing createChannels mock. fix: Add missing createChannels mock. Oct 15, 2024
Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one - thank you!
approved the CI run and assuming it's green I'll merge and it'll be in the next release, much appreciated

@mikehardy mikehardy added the pending-merge Waiting on CI or question responses to merge, but otherwise ready label Oct 15, 2024
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.08%. Comparing base (75d494f) to head (1ecfd76).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1123   +/-   ##
=======================================
  Coverage   77.08%   77.08%           
=======================================
  Files          32       32           
  Lines        1727     1727           
  Branches      579      579           
=======================================
  Hits         1331     1331           
- Misses        343      395   +52     
+ Partials       53        1   -52     

@mikehardy mikehardy merged commit bf9618e into invertase:main Oct 18, 2024
12 checks passed
@mikehardy mikehardy removed the pending-merge Waiting on CI or question responses to merge, but otherwise ready label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants