docs: publish notifee docs via docs.page #1171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… spot this gets our release notes in the docs.page future up to date and set to auto-update going forward
|
To view this pull requests documentation preview, visit the following URL: docs.page/invertase/notifee~1171 Documentation is deployed and generated using docs.page. |
- workflow path exclusions - gitattributes etc - CONTRIBUTING information - typedoc generation
so focused on semantic release publish workflow yesterday (which was set to use `lts/*` as node spec) that I didn't realize pulling semantic-release dep in bumped minimum acceptable node to 20 and we were on 18 in most workflows
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1171 +/- ##
=======================================
Coverage 77.08% 77.08%
=======================================
Files 32 32
Lines 1727 1727
Branches 579 556 -23
=======================================
Hits 1331 1331
Misses 395 395
Partials 1 1 |
|
docs preview site looks good, and proves that I've installed the docs.page bot correctly so we get PR comments with the link to a live preview, also a big win |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements docs.page publishing for the notifee documentation
Reference (typescript typedocs...) docs will still be unpublished and have broken links after this, but at least the documentation will finally finally be up again vs having to repository-browse it with no linking