Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(messaging, android): handle nullable broadcast intent (#7893) #7960

Merged
merged 2 commits into from
Aug 19, 2024

Conversation

divineniiquaye
Copy link
Contributor

@divineniiquaye divineniiquaye commented Aug 7, 2024

Description

Add a check to handle scenarios where the broadcast intent comes with no extras, preventing potential crashes and logging an error for better debugging.

This ensures stability when processing message broadcasts without extras.

Related issues

Closes #7893

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

…7893)

Add a check to handle scenarios where the broadcast intent comes with no extras, preventing potential crashes and logging an error for better debugging.
Copy link

vercel bot commented Aug 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 14, 2024 9:45am

@CLAassistant
Copy link

CLAassistant commented Aug 7, 2024

CLA assistant check
All committers have signed the CLA.

@divineniiquaye divineniiquaye changed the title fix(messaging, android): handle nullable broadcast intent (#7893) fix(messaging, android): handle nullable broadcast intent Aug 7, 2024
@divineniiquaye divineniiquaye changed the title fix(messaging, android): handle nullable broadcast intent fix(messaging, android): handle nullable broadcast intent (#7893) Aug 8, 2024
@russellwheatley
Copy link
Member

Providing this passes CI, I'm happy for this to go in 👍

@russellwheatley russellwheatley added plugin: messaging FCM only - ( messaging() ) - do not use for Notifications Workflow: Pending Merge Waiting on CI or similar labels Aug 14, 2024
@russellwheatley russellwheatley merged commit c1ac022 into invertase:main Aug 19, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin: messaging FCM only - ( messaging() ) - do not use for Notifications Workflow: Pending Merge Waiting on CI or similar
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐛] Android Crash "Unable to start receiver"
4 participants