Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app, sdk): firebase-android-sdk 33.5.1 #8095

Merged
merged 2 commits into from
Oct 31, 2024

Conversation

mikehardy
Copy link
Collaborator

@mikehardy mikehardy commented Oct 28, 2024

Description

underlying fixes but nothing visible for / necessary from library consumers

Related issues

Nothing logged, but:

  • android updated protobuf to solve a security CVE

  • the saga of FirebaseCoreExtension is what drove the iOS SDK patch releases - unfortunately we can't really do a 11.4.2 release because firestore did not actually bump except some of it's internal/transitives, so firestore-ios-sdk-frameworks won't generate a release, it will have to wait for 11.5.0

Release Summary

a single conventional commit, rebase merge + release should do the trick

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan

Incorporated in my rnfbdemo build tests successfully, CI will qualify it here


Think react-native-firebase is great? Please consider supporting the project with any of the below:

@mikehardy mikehardy added the Workflow: Needs Review Pending feedback or review from a maintainer. label Oct 28, 2024
Copy link

vercel bot commented Oct 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2024 2:58pm

@mikehardy mikehardy force-pushed the @mikehardy/20241028-sdk-updates branch from 9472e5c to 5801efa Compare October 28, 2024 19:06
@mikehardy mikehardy force-pushed the @mikehardy/20241028-sdk-updates branch from 5801efa to 8b8c08e Compare October 28, 2024 19:57
@mikehardy mikehardy changed the title fix(app, sdk): firebase-android-sdk 33.5.1 / firebase-ios-sdk 11.4.2 fix(app, sdk): firebase-android-sdk 33.5.1 Oct 28, 2024
@mikehardy mikehardy removed the Workflow: Needs Review Pending feedback or review from a maintainer. label Oct 28, 2024
@mikehardy mikehardy added the Workflow: Needs Review Pending feedback or review from a maintainer. label Oct 28, 2024
underlying fixes but nothing visible for / necessary from library consumers
@mikehardy mikehardy merged commit a5feba3 into main Oct 31, 2024
18 of 19 checks passed
@mikehardy mikehardy deleted the @mikehardy/20241028-sdk-updates branch October 31, 2024 12:38
@mikehardy mikehardy removed the Workflow: Needs Review Pending feedback or review from a maintainer. label Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants