Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): load workflow from file #7254

Merged
merged 1 commit into from
Nov 4, 2024

Commits on Nov 4, 2024

  1. fix(ui): load workflow from file

    In a8de640 a change was made to many menus in an effort to improve performance. The menus were made to be lazy, so that they are mounted only while open.
    
    This causes unexpected behaviour when there is some logic in the menu that may need to execute after the user selects a menu item.
    
    In this case, when you click to load a workflow from file, the file picker opens but then the menuitem unmounts, taking the input element and all uploading logic with it. When you select a file, nothing happens because we've nuked the handlers by unmounting everything.
    
    Easy fix - un-lazy-fy the menu.
    
    Closes #7240
    psychedelicious authored and hipsterusername committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    cf2e0f9 View commit details
    Browse the repository at this point in the history