-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update bundle 2. #73
base: master
Are you sure you want to change the base?
Update bundle 2. #73
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @aaybala,
Thanks for taking time to update the bundles.
I saw your changes, however it is missing a pdf file. You should render the .tex file and upload the updated pdf file(02-algorithms-01.pdf).
I can review more precisely on pdf file.
Also, you can add me as a reviewer to the overleaf project, and I can left my reviews on Overleaf too.
I think instead of minor fixes, some paragraphs needs to rewritten as more simple form.
@@ -424,7 +429,7 @@ | |||
|
|||
\textbf{Procedure: } | |||
\begin{enumerate} | |||
\item For each digit from the least significant to the most, sort the array using \textit{Counting Sort} according to corresponding digit. \textit{Counting Sort} is used for keys between specific range, and it counts the number of elements which have different key values. After counting the number of distict key values, we can determine the position of elements in the array. | |||
\item For each digit from the least significant to the most, sort the array using \textit{Radix Sort} according to the corresponding digit. \textit{Radix Sort} is used for keys between specific range, and it counts the number of elements that have different key values. After counting the number of distinct key values, we can determine the position of elements in the array. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be remain as 'counting sort',
It is saying that digits should be sorted using counting sort. So both, of them should remain as Counting Sort.
But, I think this text very hard to understand. Can you rewrite the whole procedure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uups, I think it should be fine now. Could you review again?
Hi @kayacanv, thank you for the review! I applied the changes you requested. I also added you to the Overleaf project. |
I left some comments on overleaf |
Thanks for the review! I resolved some comments but couldn't understand one of them, could you please take another look :) I won't reupload the pdf here again until we have the final version. Thanks. |
No description provided.