Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove debug and replace with disabled preference #251

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: remove debug and replace with disabled preference #251

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions docs/interfaces/ideployconfig.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ The configuration for the deploy plugin on the device.

* [appId](ideployconfig.md#appid)
* [channel](ideployconfig.md#channel)
* [debug](ideployconfig.md#debug)
* [disabled](ideployconfig.md#disabled)
* [host](ideployconfig.md#host)
* [maxVersions](ideployconfig.md#maxversions)
* [minBackgroundDuration](ideployconfig.md#minbackgroundduration)
Expand Down Expand Up @@ -42,13 +42,13 @@ ___
The [channel](https://ionicframework.com/docs/pro/deploy/channels) that the plugin should listen for updates on.

___
<a id="debug"></a>
<a id="disabled"></a>

### `<Optional>` debug
### `<Optional>` disabled

**● debug**: *`undefined` \| `true` \| `false`*
**● disabled**: *`undefined` \| `true` \| `false`*

whether or not the app should in debug mode
Whether the user disabled deploy updates or not.

___
<a id="host"></a>
Expand Down
4 changes: 2 additions & 2 deletions www/IonicCordova.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,9 +154,9 @@ export interface IDeployConfig {
appId?: string;

/**
* whether or not the app should in debug mode
* Whether the user disabled deploy updates or not.
*/
debug?: boolean;
disabled?: boolean;

/**
* @ignore
Expand Down
2 changes: 1 addition & 1 deletion www/guards.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ export function isPluginConfig(o: object): o is IDeployConfig {
return obj &&
(obj.appId === undefined || typeof obj.appId === 'string') &&
(obj.channel === undefined || typeof obj.channel === 'string') &&
(obj.debug === undefined || typeof obj.debug === 'string') &&
(obj.disabled === undefined || typeof obj.disabled === 'string') &&
(obj.updateMethod === undefined || typeof obj.updateMethod === 'string') &&
(obj.maxVersions === undefined || typeof obj.maxVersions === 'number') &&
(obj.minBackgroundDuration === undefined || typeof obj.minBackgroundDuration === 'number') &&
Expand Down