fix(react): improve resolving component types #583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dwirz thanks for raising the PR, let me take a look at this after Christmas 😉 |
|
No worries, thanks a lot for your time and review. Happy Christmas 🙂 btw somehow the |
No, this may be related to webdriverio/webdriverio#14011 |
dwirz
force-pushed
the
fix/use-same-logic-to-resolve-sub-type
branch
from
0474a7c to
08ad3b5
Compare
|
@christian-bromann My bad! I renamed the test but forgot to update the snapshots, so the names ended up misaligned. 🤦♂️ |
christian-bromann
approved these changes
Dec 26, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally for affected output targetsnpm test) were run locally and passednpm run prettier) was run locally and passedPull request type
Please check the type of change your PR introduces:
What is the current behavior?
There are still some cases where resolving the correct types fails, which results in warnings and, occasionally, incorrectly rendered content.
Issue URL: #561
What is the new behavior?
Resolve component types correctly also for nested and lazy components.
Does this introduce a breaking change?
Other information
I’ve added some new components and new tests to the Next.js example project to verify that the generated HTML includes the expected Declarative Shadow DOM.