-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(vitest): add Vitest option to testing section #1407
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christian-bromann
requested review from
rwaskiewicz and
alicewriteswrongs
and removed request for
a team
April 18, 2024 22:05
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
alicewriteswrongs
suggested changes
May 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a good addition I think! Just noticed a few things we might want to tweak
Co-authored-by: Alice Pote <alice.writes.wrongs@gmail.com>
@alicewriteswrongs thanks for your feedback, addressed all comments. |
alicewriteswrongs
approved these changes
May 8, 2024
alicewriteswrongs
requested review from
tanner-reits
and removed request for
rwaskiewicz
May 8, 2024 18:47
tanner-reits
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds another option for testing Stencil components using Vitest. While this option has its limitation (no auto-waits and no mocking) it still is an option that is useable and worth to document.