Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(vitest): add Vitest option to testing section #1407

Merged
merged 5 commits into from
May 9, 2024

Conversation

christian-bromann
Copy link
Member

This patch adds another option for testing Stencil components using Vitest. While this option has its limitation (no auto-waits and no mocking) it still is an option that is useable and worth to document.

@christian-bromann christian-bromann requested a review from a team as a code owner April 18, 2024 22:05
@christian-bromann christian-bromann requested review from rwaskiewicz and alicewriteswrongs and removed request for a team April 18, 2024 22:05
Copy link

vercel bot commented Apr 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
stencil-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2024 3:19pm

Copy link
Contributor

@alicewriteswrongs alicewriteswrongs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a good addition I think! Just noticed a few things we might want to tweak

docs/testing/03-vitest.md Outdated Show resolved Hide resolved
docs/testing/03-vitest.md Outdated Show resolved Hide resolved
docs/testing/03-vitest.md Outdated Show resolved Hide resolved
docs/testing/03-vitest.md Outdated Show resolved Hide resolved
christian-bromann and others added 3 commits May 8, 2024 08:43
Co-authored-by: Alice Pote <alice.writes.wrongs@gmail.com>
@christian-bromann
Copy link
Member Author

@alicewriteswrongs thanks for your feedback, addressed all comments.

@alicewriteswrongs alicewriteswrongs requested review from tanner-reits and removed request for rwaskiewicz May 8, 2024 18:47
@christian-bromann christian-bromann merged commit 4338513 into main May 9, 2024
5 checks passed
@christian-bromann christian-bromann deleted the cb/vitest-tutorial branch May 9, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants