Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add better docs for SSR support #1490

Merged
merged 11 commits into from
Oct 24, 2024
Merged

docs: add better docs for SSR support #1490

merged 11 commits into from
Oct 24, 2024

Conversation

christian-bromann
Copy link
Member

Adding more docs around doing SSR with Stencil.

Copy link

vercel bot commented Oct 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
stencil-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2024 8:57pm

@christian-bromann christian-bromann marked this pull request as ready for review October 22, 2024 23:42
@christian-bromann christian-bromann requested a review from a team as a code owner October 22, 2024 23:42
@christian-bromann christian-bromann requested review from gnbm and tanner-reits and removed request for a team October 22, 2024 23:42
Copy link

@gnbm gnbm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Member

@tanner-reits tanner-reits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple tweaks, but overall looks good. The SSR pitfalls/tips is great!

docs/framework-integration/react.md Outdated Show resolved Hide resolved
docs/framework-integration/react.md Outdated Show resolved Hide resolved
docs/framework-integration/react.md Outdated Show resolved Hide resolved
docs/framework-integration/vue.md Outdated Show resolved Hide resolved
docs/framework-integration/vue.md Outdated Show resolved Hide resolved
docs/framework-integration/vue.md Outdated Show resolved Hide resolved
christian-bromann and others added 6 commits October 23, 2024 10:42
Co-authored-by: Tanner Reits <47483144+tanner-reits@users.noreply.github.com>
Co-authored-by: Tanner Reits <47483144+tanner-reits@users.noreply.github.com>
Co-authored-by: Tanner Reits <47483144+tanner-reits@users.noreply.github.com>
Co-authored-by: Tanner Reits <47483144+tanner-reits@users.noreply.github.com>
Co-authored-by: Tanner Reits <47483144+tanner-reits@users.noreply.github.com>
@christian-bromann
Copy link
Member Author

@tanner-reits updated with your suggestions, any further feedback?

Copy link
Member

@tanner-reits tanner-reits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@christian-bromann christian-bromann merged commit 3e25c20 into main Oct 24, 2024
5 checks passed
@christian-bromann christian-bromann deleted the cb/ssr-docs branch October 24, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants