Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exclude only /logs folder from rsync and not every other folder insid… #4

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Freezle
Copy link
Contributor

@Freezle Freezle commented Oct 28, 2021

…e the tree that has this name

@coder-hugo
Copy link
Member

With this change rsync will remove all logs within other logs directories during the recurring deployments. I expect that this is also not what we want. Additionally I'm unsure if this will work with the current way we calculate the size of the remote excludes.

@Freezle
Copy link
Contributor Author

Freezle commented Oct 29, 2021

I would expect that users add their own log folders to exclude in recurring. For example in Laravel storage is added to recurring excludes, and in storage is the logs folder. The basic issue was the following: the Laravel starter has a storage folder and in this folder are three empty folders (except a .gitignore) - app, framework and logs. app and framework reached the server, but logs not. And I think it's incomprehensible for the user why the folder is missing and Laravel don't log anything.

@coder-hugo
Copy link
Member

Ok, you are right. but we have to adapt the code that calculates the size of the remote excludes since this doesn't work with the leading slash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants