Skip to content

fix crate name

fix crate name #5

Triggered via push March 25, 2024 09:21
Status Failure
Total duration 45s
Artifacts

rust.yml

on: push
Fit to window
Zoom out
Zoom in

Annotations

6 errors and 2 warnings
you should consider adding a `Default` implementation for `Path<'a>`: src/did.rs#L284
error: you should consider adding a `Default` implementation for `Path<'a>` --> src/did.rs:284:5 | 284 | / pub const fn new() -> Self { 285 | | Self(Cow::Borrowed("")) 286 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default = note: `-D clippy::new-without-default` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::new_without_default)]` help: try adding this | 283 ~ impl<'a> Default for Path<'a> { 284 + fn default() -> Self { 285 + Self::new() 286 + } 287 + } 288 + 289 ~ impl<'a> Path<'a> { |
non-canonical implementation of `partial_cmp` on an `Ord` type: src/did.rs#L195
error: non-canonical implementation of `partial_cmp` on an `Ord` type --> src/did.rs:195:1 | 195 | / impl PartialOrd for DID { 196 | | fn partial_cmp(&self, other: &Self) -> Option<Ordering> { | | ___________________________________________________________- 197 | || self.as_str().partial_cmp(other.as_str()) 198 | || } | ||___- help: change this to: `{ Some(self.cmp(other)) }` 199 | | } | |__^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl = note: `-D clippy::non-canonical-partial-ord-impl` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::non_canonical_partial_ord_impl)]`
deref which would be done by auto-deref: src/did.rs#L72
error: deref which would be done by auto-deref --> src/did.rs:72:5 | 72 | &*self.data | ^^^^^^^^^^^ help: try: `&self.data` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref = note: `-D clippy::explicit-auto-deref` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::explicit_auto_deref)]`
calling `insert_str()` using a single-character string literal: src/core.rs#L114
error: calling `insert_str()` using a single-character string literal --> src/core.rs:114:9 | 114 | buffer.insert_str(fragment as usize, "?"); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `insert` with a character literal: `buffer.insert(fragment as usize, '?')` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str = note: `-D clippy::single-char-add-str` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::single_char_add_str)]`
unnecessary closure used to substitute value for `Option::None`: src/core.rs#L92
error: unnecessary closure used to substitute value for `Option::None` --> src/core.rs:92:20 | 92 | let end: u32 = self | ____________________^ 93 | | .query 94 | | .or(self.fragment) 95 | | .unwrap_or_else(|| buffer.len() as u32); | |________-------------------------------------^ | | | help: use `unwrap_or(..)` instead: `unwrap_or(buffer.len() as u32)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations = note: `-D clippy::unnecessary-lazy-evaluations` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::unnecessary_lazy_evaluations)]`
build
Clippy had exited with the 101 exit code
build
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions-rs/cargo@v1, actions-rs/clippy-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
build
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/cargo@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/