Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade async-graphql deps #4128

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

samuel-rufi
Copy link
Member

@samuel-rufi samuel-rufi commented Nov 19, 2024

Description of change

Upgrade async-graphql deps

Links to any relevant issues

Aims to fix #4121

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How the change has been tested

cd crates/iota-graphql-e2e-tests
cargo nextest run --features pg_integration
cd crates/iota-graphql-rpc
cargo nextest run -p iota-graphql-rpc --features pg_integration --no-fail-fast --test-threads 1

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@samuel-rufi samuel-rufi self-assigned this Nov 19, 2024
Copy link
Contributor

@kodemartin kodemartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samuel-rufi you can simplify the impl Loader blocks by simply removing the #[async_trait::async_trait].

See this suggestion in the respective discussion after the breaking change with the Loader trait refactoring.

clippy also raises the manual async lint, at least locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[iota-graphql-rpc]: Upgrade async-graphql
2 participants