fix(rest-api): Avoid panic in append_info_headers #4178
+21
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuel-rufi
reviewed
Nov 21, 2024
crates/iota-rest-api/src/response.rs
Outdated
| *checkpoint.sequence_number(), | ||
| checkpoint.timestamp_ms, | ||
| ), | ||
| Err(_) => (0, 0, 0), |
There was a problem hiding this comment.
Instead of ignoring the error, it might be better to return it from this function. Overriding the error with (0,0,0) doesn't seem good to me, also because it might be an important error from the state reader.
bingyanglin
reviewed
Nov 25, 2024
crates/iota-rest-api/src/response.rs
Outdated
Comment on lines
131
to
133
| pub enum HeaderError { | ||
| InternalServerError(String), | ||
| } |
There was a problem hiding this comment.
I am not very sure whether it is necessary to introduce a new HeaderError, or maybe you can just use the RestErrordefined in the iota-rest-api crate?
|
It seems that this issue was already fixed in the upstream. They just ignore the header if the corresponding object is not found instead of failing with internal server error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
The REST API might cause the node to panic if
append_info_headersfails to retrieve the data. This PR updatesappend_info_headersto return an internal server error when it fails.Links to any relevant issues
Close #4087
Type of change
Change checklist