fix(clippy): 1.83's empty_line_after_outer_attr and empty_line_after_doc_comments
#4639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iota-ci
added
dev-tools
| @@ -560,13 +560,11 @@ pub struct ProtocolConfig { | |||
| // entire object, just consulting an ID -> tx digest map | |||
| obj_access_cost_verify_per_byte: Option<u64>, | |||
|
|
|||
| /// === Gas version. gas model === | |||
|
|
|||
| // === Gas version. gas model === | |||
There was a problem hiding this comment.
Side-effect is that formatting removes the newline though :(
Thoralf-M
approved these changes
Dec 30, 2024
thibault-martinez
changed the title
empty_line_after_outer_attrempty_line_after_outer_attr and empty_line_after_doc_comments
Comment on lines
+575
to
+577
| #[rustfmt::skip] | ||
| #[allow(clippy::empty_line_after_outer_attr)] | ||
| // Tables for recording state for RandomnessManager. |
There was a problem hiding this comment.
Could maybe just do this?
Suggested change
| #[rustfmt::skip] | |
| #[allow(clippy::empty_line_after_outer_attr)] | |
| // Tables for recording state for RandomnessManager. | |
| // Tables for recording state for RandomnessManager. | |
| // |
There was a problem hiding this comment.
Or possibly two consecutive newlines
There was a problem hiding this comment.
PR is basically draft because I don't know what to do about this :(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These comments used as separators shouldn't be doc comments.
https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments