Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deps): ESM deps should be dev-only #100

Merged
merged 2 commits into from
Nov 8, 2022
Merged

fix(deps): ESM deps should be dev-only #100

merged 2 commits into from
Nov 8, 2022

Conversation

whizzzkid
Copy link
Collaborator

Blocks: ipfs/ipfs-webui#2061

In this PR:

  • Updated Dependencies to be dev only.
  • ESM ships with everything needed.

@whizzzkid whizzzkid requested review from lidel and SgtPooki November 2, 2022 21:18
@whizzzkid whizzzkid requested a review from a team as a code owner November 2, 2022 21:18
@whizzzkid whizzzkid mentioned this pull request Nov 2, 2022
Merged
whizzzkid
whizzzkid commented Nov 2, 2022
View reviewed changes
.aegir.js
Comment on lines +3 to +10
dependencyCheck: {
input: [
'dist/**/*.js',
],
productionInput: [
'dist/**/*.js',
],
},
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created an issue for this: ipfs/aegir#1104

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment on ipfs/aegir#1104 (comment)

@whizzzkid whizzzkid mentioned this pull request Nov 3, 2022
Open
3 tasks
@SgtPooki SgtPooki mentioned this pull request Nov 3, 2022
Open
SgtPooki
SgtPooki reviewed Nov 3, 2022
View reviewed changes
Copy link
Member

@SgtPooki SgtPooki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a comment on ipfs/aegir#1104 (comment). If those assumptions are true, then I'm fine with this PR.. lmk

lidel
lidel approved these changes Nov 7, 2022
View reviewed changes
Copy link
Member

@lidel lidel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but we should park this until #99 (protocol/.github#410) is set up, so when this PR is merged a patch release happens automatically

@whizzzkid
Copy link
Collaborator Author

@lidel absolutely.

@lidel
Copy link
Member

lidel commented Nov 8, 2022

Seems things are set up for automatic release: https://github.com/ipfs-shipyard/ipfs-geoip/actions/runs/3421056172/jobs/5697575441#step:6:62

Let's merge and see if it autoreleases this.

@lidel lidel merged commit 5bd8b60 into main Nov 8, 2022
@lidel lidel deleted the fix/dependencies branch November 8, 2022 17:03
github-actions bot pushed a commit that referenced this pull request Nov 8, 2022
@semantic-release-bot
chore(release): 9.0.1 [skip ci]
3d80c74 
## [9.0.1](v9.0.0...v9.0.1) (2022-11-08)

### Bug Fixes

* **deps:** ESM deps should be dev-only ([#100](#100)) ([5bd8b60](5bd8b60))
@github-actions
Copy link

github-actions bot commented Nov 8, 2022

🎉 This PR is included in version 9.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SgtPooki SgtPooki SgtPooki approved these changes

@lidel lidel lidel approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@whizzzkid @lidel @SgtPooki