Skip to content

Commit

Permalink
update changelog
Browse files Browse the repository at this point in the history
  • Loading branch information
gammazero committed Dec 3, 2024
1 parent da800d8 commit 39c797e
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ The following emojis are used to highlight certain changes:
- `routing/http/client`: creating delegated routing client with `New` now defaults to querying delegated routing server with `DefaultProtocolFilter` ([IPIP-484](https://github.com/ipfs/specs/pull/484)) [#689](https://github.com/ipfs/boxo/pull/689)
- `bitswap/client`: Wait at lease one broadcast interval before resending wants to a peer. Check for peers to rebroadcast to more often than one broadcast interval.
- No longer using `github.com/jbenet/goprocess` to avoid requiring in dependents. [#710](https://github.com/ipfs/boxo/pull/710)
- Refactor remote pinning `Ls` to take results channel instead of returning one. The previous `Ls` behavior is implemented by the GoLs function, which creates the channels, starts the goroutine that calls Ls, and returns the channels to the caller

### Removed

Expand Down
4 changes: 1 addition & 3 deletions pinning/remote/client/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ func (c *Client) Ls(ctx context.Context, res chan<- PinStatusGetter, opts ...LsO
batchSize := len(results)
if int(pinRes.Count) == batchSize {
// no more batches
break
return nil
}

Check warning on line 197 in pinning/remote/client/client.go

View check run for this annotation

Codecov / codecov/patch

pinning/remote/client/client.go#L193-L197

Added lines #L193 - L197 were not covered by tests

// Better DX/UX for cases like https://github.com/application-research/estuary/issues/124
Expand All @@ -204,8 +204,6 @@ func (c *Client) Ls(ctx context.Context, res chan<- PinStatusGetter, opts ...LsO
oldestResult := results[batchSize-1]
settings.before = &oldestResult.Created

Check warning on line 205 in pinning/remote/client/client.go

View check run for this annotation

Codecov / codecov/patch

pinning/remote/client/client.go#L204-L205

Added lines #L204 - L205 were not covered by tests
}

return nil
}

// GoLs creates the results and error channels, starts the goroutine that calls
Expand Down

0 comments on commit 39c797e

Please sign in to comment.