Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate go-unixfsnode #25

Merged
merged 54 commits into from
Jan 13, 2023
Merged

Migrate go-unixfsnode #25

merged 54 commits into from
Jan 13, 2023

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented Jan 12, 2023 •
edited
Loading

See #26. Moved into the subdirectory unixfs/node. My thoguhts is that we could make go-unixfs go into unixfs, unixfs/unixfs or unixfs/impl.

hannahhoward and others added 30 commits March 4, 2021 17:46
@hannahhoward
first commit
1e82733 
This commit was moved from ipfs/go-unixfsnode@05d5109
@hannahhoward
feat(unixfsnode): initial implementation
cd049e0 
This commit was moved from ipfs/go-unixfsnode@f2af51a
@hannahhoward
feat(data): add unixfs data node decoding
eabd475 
add builders and utitlities for working with unixfs data protobufs


This commit was moved from ipfs/go-unixfsnode@4574e41
@hannahhoward
feat(hamt): add hamt implementation
8c66104 
Add HAMT Implementation + Shared iterator to use with basic directory


This commit was moved from ipfs/go-unixfsnode@cdb32f2
@hannahhoward
feat(directory): seperate directory implementation
d37f474 
move basic directory to its own package, redo root package based on more flexible refication and
more flexible node prototype


This commit was moved from ipfs/go-unixfsnode@67a7e38
@hannahhoward
fix(unixfsnode): have reifier add path selection to normal nodes
34a81a1 
have reifier add path selection to all protobuf nodes, even ones that are not unixfs


This commit was moved from ipfs/go-unixfsnode@d6733f6
@hannahhoward
fix(unixfsnode): cleanup from comments
1e0dabf 
respond to PR comments -- make error types, etc


This commit was moved from ipfs/go-unixfsnode@1854f92
@hannahhoward
feat(reification): use new prime node reification
45a1a9a 
Use ipld-primes reifier to avoid uncomfortable node prototype stuff


This commit was moved from ipfs/go-unixfsnode@de45652
@hannahhoward
fix(unixfsnode): respond to PR comments
f25054d 
This commit was moved from ipfs/go-unixfsnode@e56e007
@hannahhoward
Merge pull request ipfs/go-unixfsnode#4 from ipfs/feat/support-hamt
af10b84 
Support HAMT

This commit was moved from ipfs/go-unixfsnode@5a89cd4
@hannahhoward
feat(reifier): don't error on missing reification for now
50aff33 
This commit was moved from ipfs/go-unixfsnode@37e399d
@mvdan
data: update ipld-prime version to fix codegen issues
84c68c4 
The generated code now passes vet and fmt.

Three vet warnings remain, but outside generated code.


This commit was moved from ipfs/go-unixfsnode@db2fdc8
@marten-seemann
Merge pull request ipfs/go-unixfsnode#6 from mvdan/ipld-gen
bc6ef62 
data: update ipld-prime version to fix codegen issues

This commit was moved from ipfs/go-unixfsnode@e588e31
@marten-seemann
fix staticcheck
497695c 
This commit was moved from ipfs/go-unixfsnode@8c33d56
@marten-seemann
Merge pull request ipfs/go-unixfsnode#7 from ipfs/fix-staticcheck
d131639 
fix staticcheck

This commit was moved from ipfs/go-unixfsnode@6e93862
@marten-seemann
fix go vet
4516ade 
This commit was moved from ipfs/go-unixfsnode@afd1273
@marten-seemann
Merge pull request ipfs/go-unixfsnode#5 from ipfs/web3-bot/sync
4e99484 
sync: update CI config files

This commit was moved from ipfs/go-unixfsnode@852c148
@aschmahmann
make UnixFSHAMTShard implement the ADL interface (#11)
e2fc731 
* make UnixFSHAMTShard implement the ADL interface
* add checks that UnixFSBasicDir and PathedPBNode implement the ADL interface

This commit was moved from ipfs/go-unixfsnode@c7f1fe6
@willscott
Add builder for unixfs dags (#12)
1fbc9e6 
* Add builder for unixfs chunked files and directories

This commit was moved from ipfs/go-unixfsnode@e0bbe4a
@willscott
Add ADL/single-node-view of a full unixFS file. (#14)
84ecfe7 
* Add ADL/single-node-view for unixFS files.


This commit was moved from ipfs/go-unixfsnode@ef86491
@willscott
handle empty files (#15)
4d9dcdd 
This commit was moved from ipfs/go-unixfsnode@b9b6e9d
@willscott
add license (#17)
c587c00 
fix #16

This commit was moved from ipfs/go-unixfsnode@d21ca04
@aschmahmann
chore: update deps
f3fe24f 
This commit was moved from ipfs/go-unixfsnode@b2ae22e
@hannahhoward
feat(unixfsnode): add utils for signalling for selectors
9b82c04 
This commit was moved from ipfs/go-unixfsnode@c487b3d
@hannahhoward
Merge pull request ipfs/go-unixfsnode#20 from ipfs/feat/update-deps
abdd6a5 
Update deps for ADL selectors

This commit was moved from ipfs/go-unixfsnode@1a8e71b
@rvagg
fix: encode Tsize correctly everywhere (using wraped LinkSystem)
ee986c8 
This commit was moved from ipfs/go-unixfsnode@981d684
@rvagg
fix: more Tsize fixes, fix HAMT and make it match go-unixfs output
1690969 
This commit was moved from ipfs/go-unixfsnode@bbf0ec6
@rvagg
fix: add extra test to span the shard/no-shard boundary
79823b0 
This commit was moved from ipfs/go-unixfsnode@d3fccee
@willscott
add AsLargeBytes support to unixfs files (#24)
1790dea 
* add AsLargeBytes support to unixfs files


This commit was moved from ipfs/go-unixfsnode@94986a7
@hannahhoward
fix(unixfsnode): add unixfs to path tail
ab5e7d1 
fix the selector for paths, wrapping the last matcher node in an ExploreInterpretAs, since the tail
end of a path into a unixfs dir is itself a unixfsnode


This commit was moved from ipfs/go-unixfsnode@9214f70
willscott and others added 14 commits August 20, 2022 14:40
@willscott
split large file test to not run with race detector, sine that's too …
5031cf0 
…big for CI

This commit was moved from ipfs/go-unixfsnode@05a4b16
@willscott
Merge pull request ipfs/go-unixfsnode#34 from ipfs/largeFileReads
d6e5e1e 
test for reader / sizing behavior on large files

This commit was moved from ipfs/go-unixfsnode@1fca571
@web3-bot @rvagg
bump go.mod to Go 1.18 and run go fix
bf32171 
This commit was moved from ipfs/go-unixfsnode@d076d37
@web3-bot @rvagg
run gofmt -s
0059950 
This commit was moved from ipfs/go-unixfsnode@c65306a
@rvagg
fix: remove use of ioutil
a7ae3e7 
This commit was moved from ipfs/go-unixfsnode@4afe29f
@willscott
add an ADL to preload hamt loading
4470d12 
This commit was moved from ipfs/go-unixfsnode@e95359d
@willscott
remaining linking
7957235 
This commit was moved from ipfs/go-unixfsnode@04e6d4d
@willscott
Update file/file.go
e438fa7 
Co-authored-by: Rod Vagg <rod@vagg.org>

This commit was moved from ipfs/go-unixfsnode@79130b4
@willscott
expand readme a bit
d91d973 
This commit was moved from ipfs/go-unixfsnode@f9e443f
@willscott
Merge pull request ipfs/go-unixfsnode#38 from ipfs/feat/preload
a48c4ab 
add an ADL to preload hamt loading

This commit was moved from ipfs/go-unixfsnode@475ed65
@bachue
fix a possible index out of range crash
971cdf4 
This commit was moved from ipfs/go-unixfsnode@3771b58
@willscott
Merge pull request ipfs/go-unixfsnode#39 from bachue/fix/crash
f46daff 
fix a possible `index out of range` crash

This commit was moved from ipfs/go-unixfsnode@30b9fb2
@hacdias
Merge commits from ipfs/go-unixfsnode/main
2fed26c
@hacdias
chore: go mod tidy
0d10ff9
@hacdias hacdias mentioned this pull request Jan 12, 2023
Open
7 tasks
@hacdias hacdias requested review from guseggert and ajnavarro and removed request for guseggert January 12, 2023 11:11
@hacdias hacdias self-assigned this Jan 12, 2023
@hacdias hacdias marked this pull request as ready for review January 12, 2023 11:12
@hacdias hacdias marked this pull request as draft January 12, 2023 11:13
@hacdias hacdias marked this pull request as ready for review January 12, 2023 11:33
@hacdias hacdias merged commit 4d71fa3 into main Jan 13, 2023
@hacdias hacdias deleted the migrate-unixfsnode branch January 13, 2023 13:00
@lidel lidel mentioned this pull request Jan 17, 2023
Merged
lidel added a commit that referenced this pull request Jan 18, 2023
@lidel
Revert "Merge pull request #25 from ipfs/migrate-unixfsnode"
1fa33d0 
This reverts commit 4d71fa3, reversing
changes made to 6736733.

Context for this decision can be found in
#26
lidel added a commit that referenced this pull request Jan 18, 2023
@lidel
Revert "Merge pull request #25 from ipfs/migrate-unixfsnode"
64f8830 
This reverts commit 4d71fa3, reversing
changes made to 6736733.

Context for this decision can be found in
#26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajnavarro ajnavarro ajnavarro approved these changes

@guseggert guseggert Awaiting requested review from guseggert

Assignees

@hacdias hacdias

Labels
None yet
Projects
No open projects
IPFS Shipyard Team
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@hacdias @ajnavarro @hannahhoward @mvdan @marten-seemann @aschmahmann @willscott @rvagg @web3-bot @bachue