Feat: reduce globals #324
Closed
Feat: reduce globals #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #324 +/- ##
==========================================
+ Coverage 49.51% 49.55% +0.03%
==========================================
Files 282 282
Lines 33836 33844 +8
==========================================
+ Hits 16755 16770 +15
Misses 15316 15316
+ Partials 1765 1758 -7
|
aschmahmann
force-pushed
the
feat/reduce-globals
branch
from
0dcbacc to
8028e81
Compare
14 tasks
…ixfs.v1.pbto prevent collisions with go-merkledag
… collisions with go-unixfs. Also regenerate protobufs with latest gogo
…gistry instead of a shared global registry
aschmahmann
force-pushed
the
feat/reduce-globals
branch
from
8028e81 to
922a186
Compare
|
relevant PRs merged so this branch is no longer needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing with all the changes related to fixing #291