feat(gateway): support for order=, dups= parameters from IPIP-412 #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #370 +/- ##
==========================================
+ Coverage 49.17% 49.36% +0.18%
==========================================
Files 245 245
Lines 29812 29886 +74
==========================================
+ Hits 14660 14753 +93
+ Misses 13713 13695 -18
+ Partials 1439 1438 -1
|
hacdias
force-pushed
the
ipip-412
branch
3 times, most recently
from
b28776f to
2f2e7f2
Compare
hacdias
force-pushed
the
ipip-412
branch
2 times, most recently
from
819c808 to
cf9117b
Compare
hacdias
changed the title
hacdias
changed the title
2 tasks
hacdias
force-pushed
the
ipip-412
branch
2 times, most recently
from
9b5f313 to
65cc6a8
Compare
Closed
3 tasks
|
Pushed a minor refactor in c6e10eb:
Will bubble up to Kubo and then add some tests in ipfs/gateway-conformance#87 tomorrow. |
lidel
approved these changes
Jul 19, 2023
There was a problem hiding this comment.
In case I don't get to this before you are back @hacdias, feel free to bubble this up to ipfs/kubo#9989 and ipfs/gateway-conformance#87
Closed
- adds more type safety: DuplicateBlocksPolicy is no longer a pointer to bool, and together with DagOrder has an explicit *Unspecified state. - removes passing pointer and reliance on mutation. now mutation happens only once, in buildCarParams func, where implicit defaults are set when order or dups are unspecified in the request - moved car version validation and other parameter related logic into the same build funcs - fixed a bug where ?format=car eclipsed params from Accept header
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements IPIP-412. Closes #349.