Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dspinner: RecursiveKeys(): do not hang on cancellations #727

Merged
merged 2 commits into from
Nov 26, 2024

Merge branch 'main' into fix/kubo-10593

7502f79
Select commit
Loading
Failed to load commit list.
Merged

dspinner: RecursiveKeys(): do not hang on cancellations #727

Merge branch 'main' into fix/kubo-10593
7502f79
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 26, 2024 in 0s

60.27% (-0.09%) compared to 91c4d50

View this Pull Request on Codecov

60.27% (-0.09%) compared to 91c4d50

Details

Codecov Report

Attention: Patch coverage is 36.36364% with 7 lines in your changes missing coverage. Please review.

Project coverage is 60.27%. Comparing base (91c4d50) to head (7502f79).

Files with missing lines Patch % Lines
pinning/pinner/dspinner/pin.go 36.36% 6 Missing and 1 partial ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #727      +/-   ##
==========================================
- Coverage   60.35%   60.27%   -0.09%     
==========================================
  Files         244      244              
  Lines       31029    31034       +5     
==========================================
- Hits        18728    18705      -23     
- Misses      10632    10658      +26     
- Partials     1669     1671       +2     
Files with missing lines Coverage Δ
pinning/pinner/dspinner/pin.go 58.46% <36.36%> (-0.26%) ⬇️

... and 11 files with indirect coverage changes