Bitswap default ProviderQueryManager uses explicit options #737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When specifying that the bitswap client should use the default ProviderQueryManager, to wrap the router passed in, use the existing defaults for ProviderQueryManager and so not supply non-default options.
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #737 +/- ##
==========================================
+ Coverage 60.34% 60.41% +0.07%
==========================================
Files 244 244
Lines 31029 31032 +3
==========================================
+ Hits 18723 18747 +24
+ Misses 10634 10618 -16
+ Partials 1672 1667 -5
|
aschmahmann
reviewed
Dec 3, 2024
…ative and isolate it from a PQM without options
gammazero
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set explicit options for bitswap default PQM, to make it more conservative and isolate it from a PQM without options.