Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not reset the broadcast timer if there are no wants #758

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

gammazero
Copy link
Contributor

This change removes unnecessary timer activity and calls to broadcast.

Credit to @Wondertan for finding and proposing fix.

This change removes unnecessary timer activity and calls to broadcast.
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.44%. Comparing base (7489b98) to head (022bd45).
Report is 1 commits behind head on main.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #758      +/-   ##
==========================================
+ Coverage   60.40%   60.44%   +0.03%     
==========================================
  Files         245      245              
  Lines       31101    31102       +1     
==========================================
+ Hits        18787    18799      +12     
+ Misses      10641    10632       -9     
+ Partials     1673     1671       -2     
Files with missing lines Coverage Δ
bitswap/client/internal/session/session.go 90.56% <100.00%> (+0.03%) ⬆️

... and 11 files with indirect coverage changes

@gammazero gammazero enabled auto-merge (squash) December 17, 2024 20:38
@gammazero gammazero disabled auto-merge December 17, 2024 20:38
@gammazero gammazero merged commit e11e4ed into main Dec 17, 2024
15 checks passed
@gammazero gammazero deleted the reset-bcast-timer-if-wants branch December 17, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant