[skip changelog] fix: Drop stream references on Close/Reset

[MarcoPolo]

Lets connections get GC'd sooner (possibly before the streamMessageSender is GC'd)

There's a small extension to this pr in https://github.com/ipfs/boxo/tree/marco/with-AfterFunc that uses context.AfterFunc. But even without that, from my tests, this seems to help as well.

[welcome]

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

• The context for this PR is clear, with relevant discussion, decisions
  and stakeholders linked/mentioned.

• Your contribution itself is clear (code comments, self-review for the
  rest) and in its best form. Follow the code contribution
  guidelines
  if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

• A maintainer will triage and assign priority to this PR, commenting on
  any missing things and potentially assigning a reviewer for high
  priority items.

• The PR gets reviews, discussed and approvals as needed.

• The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

[codecov]

Codecov Report

Attention: Patch coverage is 79.41176% with 7 lines in your changes missing coverage. Please review.

Project coverage is 60.51%. Comparing base (2a5c7d0) to head (af8522d).
Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
bitswap/network/ipfs_impl.go	79.41%	5 Missing and 2 partials ⚠️

@@            Coverage Diff             @@
##             main     #760      +/-   ##
==========================================
+ Coverage   60.43%   60.51%   +0.07%     
==========================================
  Files         245      245              
  Lines       31102    31126      +24     
==========================================
+ Hits        18797    18836      +39     
+ Misses      10630    10619      -11     
+ Partials     1675     1671       -4     

Files with missing lines	Coverage Δ
bitswap/network/ipfs_impl.go	79.12% <79.41%> (-2.57%)	⬇️

... and 8 files with indirect coverage changes

[hsanjuan]

What is the motivation for this? I'm not sure streams are Closed/Reset at all much, so maybe that's the real problem.

I am not sure the code needs to be concurrency-safe either. Does it? The messagequeue seems to SendMessage sequentially.

[MarcoPolo]

I am not sure the code needs to be concurrency-safe either. Does it? The messagequeue seems to SendMessage sequentially.

Correct. It's necessary if we use the AfterFunc as in this change (which was a small diff on this): https://github.com/ipfs/boxo/pull/763/files. Let me change this to remove that and move the atomic to that PR.

[gammazero]

@MarcoPolo Thank you. IMO we will want both PRs anyway since it seems like we would want to nil the connection if the context was canceled anyway. That way we have a better chance of reconnecting before using the dead connection instead of getting an error while using it.

[MarcoPolo]

Makes sense. I just tidied up this PR by moving the atomic things to the next PR.