Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary CID copying in SessionInterestManager #761

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

gammazero
Copy link
Contributor

Also reduce lock scope in some places by moving non-critical work outside of lock.

Also reduce lock scope in some places by moving non-critical work outside of lock.
@gammazero gammazero requested a review from a team as a code owner December 17, 2024 01:04
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.40%. Comparing base (8d6ac57) to head (57ea06d).
Report is 1 commits behind head on main.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #761      +/-   ##
==========================================
- Coverage   60.40%   60.40%   -0.01%     
==========================================
  Files         245      245              
  Lines       31112    31114       +2     
==========================================
+ Hits        18792    18793       +1     
- Misses      10647    10649       +2     
+ Partials     1673     1672       -1     
Files with missing lines Coverage Δ
...l/sessioninterestmanager/sessioninterestmanager.go 100.00% <100.00%> (ø)

... and 12 files with indirect coverage changes

@gammazero gammazero merged commit 8854a6f into main Dec 17, 2024
16 checks passed
@gammazero gammazero deleted the rm-cid-copying-in-sim branch December 17, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants